From de180baba3a3e7eedeb09ff7d5f4d3eff3ffc6f4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=B8ren=20Sandmann=20Pedersen?= Date: Fri, 7 Aug 2009 11:16:31 -0400 Subject: [PATCH] Fix vmx_combine_out_ca() It should multiply with just the destination alpha channel, not all four channels. --- pixman/pixman-vmx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/pixman/pixman-vmx.c b/pixman/pixman-vmx.c index 3468ad5..16db95a 100644 --- a/pixman/pixman-vmx.c +++ b/pixman/pixman-vmx.c @@ -1334,24 +1334,23 @@ vmx_combine_out_ca (pixman_implementation_t *imp, vector unsigned int vdest, vsrc, vmask; vector unsigned char tmp1, tmp2, tmp3, tmp4, edges, dest_mask, mask_mask, src_mask, store_mask; - + COMPUTE_SHIFT_MASKC (dest, src, mask); - + /* printf ("%s\n",__PRETTY_FUNCTION__); */ for (i = width / 4; i > 0; i--) { - LOAD_VECTORSC (dest, src, mask); - + vdest = pix_multiply (pix_multiply (vsrc, vmask), splat_alpha (vdest)); - + STORE_VECTOR (dest); - + src += 4; dest += 4; mask += 4; } - + for (i = width % 4; --i >= 0;) { uint32_t a = mask[i]; @@ -1359,7 +1358,7 @@ vmx_combine_out_ca (pixman_implementation_t *imp, uint32_t d = dest[i]; uint32_t da = ALPHA_8 (~d); UN8x4_MUL_UN8x4 (s, a); - UN8x4_MUL_UN8x4 (s, da); + UN8x4_MUL_UN8 (s, da); dest[i] = s; } } -- 2.7.4