From de0f803d5693591456499859c16a7927ce30fadc Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Thu, 9 Jan 2020 12:27:31 +0200 Subject: [PATCH] webrtcbin: Don't consider RTP receivers stopped We don't support stopping RTP receivers currently so let's not consider them all stopped all the time. This fixes some of the ICE/DTLS state change handling and specifically fixes the ICE gathering state. Previously the ICE gathering state was immediately going from NEW to COMPLETE because it considered all transceivers stopped and as such all activate transceivers were finished gathering ICE candidates. Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1126 --- ext/webrtc/gstwebrtcbin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ext/webrtc/gstwebrtcbin.c b/ext/webrtc/gstwebrtcbin.c index 2259f1f..6dcd672 100644 --- a/ext/webrtc/gstwebrtcbin.c +++ b/ext/webrtc/gstwebrtcbin.c @@ -1554,6 +1554,8 @@ _create_webrtc_transceiver (GstWebRTCBin * webrtc, rtp_trans = GST_WEBRTC_RTP_TRANSCEIVER (trans); rtp_trans->direction = direction; rtp_trans->mline = mline; + /* FIXME: We don't support stopping transceiver yet so they're always not stopped */ + rtp_trans->stopped = FALSE; g_array_append_val (webrtc->priv->transceivers, trans); -- 2.7.4