From ddccc5ba4479a36dd4821f0948e118438fbf2e56 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Mon, 27 Feb 2023 15:23:01 +0100 Subject: [PATCH] [CodeGen] Always expand division larger than i128 Default MaxDivRemBitWidthSupported to 128, so that divisions larger than 128 bits are always expanded, without requiring additional configuration from the target. Note that this may still emit calls to __udivti3 on 32-bit targets, which likely don't have an implementation of that builtin. However, I believe this is sufficient to fix https://github.com/llvm/llvm-project/issues/60531, because Zig must already be defining those builtins. Differential Revision: https://reviews.llvm.org/D144871 --- llvm/lib/CodeGen/TargetLoweringBase.cpp | 4 +++- llvm/test/CodeGen/Mips/idiv_large.ll | 17 +++++++++++++++++ llvm/test/CodeGen/PowerPC/idiv_large.ll | 17 +++++++++++++++++ llvm/test/CodeGen/RISCV/idiv_large.ll | 17 +++++++++++++++++ 4 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 llvm/test/CodeGen/Mips/idiv_large.ll create mode 100644 llvm/test/CodeGen/PowerPC/idiv_large.ll create mode 100644 llvm/test/CodeGen/RISCV/idiv_large.ll diff --git a/llvm/lib/CodeGen/TargetLoweringBase.cpp b/llvm/lib/CodeGen/TargetLoweringBase.cpp index 1ff8840..ac271688 100644 --- a/llvm/lib/CodeGen/TargetLoweringBase.cpp +++ b/llvm/lib/CodeGen/TargetLoweringBase.cpp @@ -724,7 +724,9 @@ TargetLoweringBase::TargetLoweringBase(const TargetMachine &tm) : TM(tm) { // with the Target-specific changes necessary. MaxAtomicSizeInBitsSupported = 1024; - MaxDivRemBitWidthSupported = llvm::IntegerType::MAX_INT_BITS; + // Assume that even with libcalls, no target supports wider than 128 bit + // division. + MaxDivRemBitWidthSupported = 128; MaxLargeFPConvertBitWidthSupported = llvm::IntegerType::MAX_INT_BITS; diff --git a/llvm/test/CodeGen/Mips/idiv_large.ll b/llvm/test/CodeGen/Mips/idiv_large.ll new file mode 100644 index 0000000..ffd263f --- /dev/null +++ b/llvm/test/CodeGen/Mips/idiv_large.ll @@ -0,0 +1,17 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=mips-- < %s | FileCheck %s +; RUN: llc -mtriple=mips64-- < %s | FileCheck %s + +define i128 @udiv_i128(i128 %x, i128 %y) nounwind { +; CHECK-LABEL: udiv_i128: +; CHECK: jal __udivti3 + %res = udiv i128 %x, %y + ret i128 %res +} + +define i129 @udiv_i129(i129 %x, i129 %y) nounwind { +; CHECK-LABEL: udiv_i129: +; CHECK-NOT: jal + %res = udiv i129 %x, %y + ret i129 %res +} diff --git a/llvm/test/CodeGen/PowerPC/idiv_large.ll b/llvm/test/CodeGen/PowerPC/idiv_large.ll new file mode 100644 index 0000000..476aaa5 --- /dev/null +++ b/llvm/test/CodeGen/PowerPC/idiv_large.ll @@ -0,0 +1,17 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=powerpc-- < %s | FileCheck %s +; RUN: llc -mtriple=powerpc64-- < %s | FileCheck %s + +define i128 @udiv_i128(i128 %x, i128 %y) nounwind { +; CHECK-LABEL: udiv_i128: +; CHECK: bl __udivti3 + %res = udiv i128 %x, %y + ret i128 %res +} + +define i129 @udiv_i129(i129 %x, i129 %y) nounwind { +; CHECK-LABEL: udiv_i129: +; CHECK-NOT: bl __ + %res = udiv i129 %x, %y + ret i129 %res +} diff --git a/llvm/test/CodeGen/RISCV/idiv_large.ll b/llvm/test/CodeGen/RISCV/idiv_large.ll new file mode 100644 index 0000000..fb7e4a4 --- /dev/null +++ b/llvm/test/CodeGen/RISCV/idiv_large.ll @@ -0,0 +1,17 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32 < %s | FileCheck %s +; RUN: llc -mtriple=riscv64 < %s | FileCheck %s + +define i128 @udiv_i128(i128 %x, i128 %y) nounwind { +; CHECK-LABEL: udiv_i128: +; CHECK: call __udivti3 + %res = udiv i128 %x, %y + ret i128 %res +} + +define i129 @udiv_i129(i129 %x, i129 %y) nounwind { +; CHECK-LABEL: udiv_i129: +; CHECK-NOT: call{{.*}}div + %res = udiv i129 %x, %y + ret i129 %res +} -- 2.7.4