From ddad0f6b2e46858d823adc45c83e38be2abaa428 Mon Sep 17 00:00:00 2001 From: Jaehong Jo Date: Wed, 26 Oct 2016 13:41:59 +0900 Subject: [PATCH] Fixed static analysis issues in RI. Add null check and initial value Change-Id: I25121862916dabd1771bbd578f3b506d01272e05 Signed-off-by: Jaehong Jo Reviewed-on: https://gerrit.iotivity.org/gerrit/13679 Reviewed-by: Jaewook Jung Tested-by: jenkins-iotivity Reviewed-by: Hyuna Jo Reviewed-by: Dave Thaler Reviewed-by: Ashok Babu Channa --- resource/csdk/connectivity/src/ip_adapter/caipserver.c | 6 ++++++ resource/csdk/stack/src/ocobserve.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/resource/csdk/connectivity/src/ip_adapter/caipserver.c b/resource/csdk/connectivity/src/ip_adapter/caipserver.c index f27f6d9..4cf997b 100644 --- a/resource/csdk/connectivity/src/ip_adapter/caipserver.c +++ b/resource/csdk/connectivity/src/ip_adapter/caipserver.c @@ -628,6 +628,12 @@ static CAResult_t CAReceiveMessage(CASocketFd_t fd, CATransportFlags_t flags) } } #endif // !defined(WSA_CMSG_DATA) + if (!pktinfo) + { + OIC_LOG(ERROR, TAG, "pktinfo is null"); + return CA_STATUS_FAILED; + } + CASecureEndpoint_t sep = {.endpoint = {.adapter = CA_ADAPTER_IP, .flags = flags}}; if (flags & CA_IPV6) diff --git a/resource/csdk/stack/src/ocobserve.c b/resource/csdk/stack/src/ocobserve.c index b49b615..3f7e17e 100644 --- a/resource/csdk/stack/src/ocobserve.c +++ b/resource/csdk/stack/src/ocobserve.c @@ -473,7 +473,7 @@ static void CheckTimedOutObserver(ResourceObserver* observer) return; } - coap_tick_t now; + coap_tick_t now = 0; coap_ticks(&now); if (observer->TTL < now) -- 2.7.4