From dd925ad21830ee59c8a5fccde5e07e7156e91588 Mon Sep 17 00:00:00 2001 From: Andrew Trick Date: Sat, 25 Oct 2014 19:59:30 +0000 Subject: [PATCH] LSR: Minor cleanup after Daniel's patch. Combine the Inserted an Done sets into a Visited set. llvm-svn: 220623 --- llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp b/llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp index e1d18e8..9ef9b05 100644 --- a/llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp +++ b/llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp @@ -3116,14 +3116,13 @@ bool LSRInstance::InsertFormula(LSRUse &LU, unsigned LUIdx, const Formula &F) { void LSRInstance::CollectLoopInvariantFixupsAndFormulae() { SmallVector Worklist(RegUses.begin(), RegUses.end()); - SmallPtrSet Inserted; - SmallPtrSet Done; + SmallPtrSet Visited; while (!Worklist.empty()) { const SCEV *S = Worklist.pop_back_val(); // Don't process the same SCEV twice - if (!Done.insert(S)) + if (!Visited.insert(S)) continue; if (const SCEVNAryExpr *N = dyn_cast(S)) @@ -3134,7 +3133,6 @@ LSRInstance::CollectLoopInvariantFixupsAndFormulae() { Worklist.push_back(D->getLHS()); Worklist.push_back(D->getRHS()); } else if (const SCEVUnknown *US = dyn_cast(S)) { - if (!Inserted.insert(US)) continue; const Value *V = US->getValue(); if (const Instruction *Inst = dyn_cast(V)) { // Look for instructions defined outside the loop. -- 2.7.4