From dd76f4cd057572a11e9330f1ae2aa737c7a14d21 Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Wed, 26 Jun 2013 14:32:21 +0100 Subject: [PATCH] evas gl_x11: Fix uninitialized use of re in eng_output_flush() In case of render_mode == EVAS_RENDER_MODE_ASYNC_INIT we're jumping directly to end which then calls evas_gl_preload_render_unlock(eng_preload_make_current, re); Make sure re is initialized with the render engine data so we don't dereference junk. Signed-off-by: Daniel Willmann --- src/modules/evas/engines/gl_x11/evas_engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/evas/engines/gl_x11/evas_engine.c b/src/modules/evas/engines/gl_x11/evas_engine.c index 7fde46a..980dc79 100644 --- a/src/modules/evas/engines/gl_x11/evas_engine.c +++ b/src/modules/evas/engines/gl_x11/evas_engine.c @@ -1472,10 +1472,10 @@ static void eng_output_flush(void *data, Evas_Render_Mode render_mode) { Render_Engine *re; + re = (Render_Engine *)data; if (render_mode == EVAS_RENDER_MODE_ASYNC_INIT) goto end; - re = (Render_Engine *)data; if (!_re_wincheck(re)) goto end; if (!re->win->draw.drew) goto end; -- 2.7.4