From dd6dd4202f3bc4f6e609ad92e2c9b1816c7f15d3 Mon Sep 17 00:00:00 2001 From: aliguori Date: Wed, 10 Dec 2008 15:12:57 +0000 Subject: [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb) monitor_readline expects buf_size to include the terminating \0, but do_change_vnc in monitor.c calls it as though it doesn't. The other site where monitor_readline reads a password (in vl.c) passes the buffer length correctly. Signed-off-by: Chris Webb Signed-off-by: Anthony Liguori git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5966 c046a42c-6fe2-441c-8c8c-71466251a162 --- monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index f142a87..bec9211 100644 --- a/monitor.c +++ b/monitor.c @@ -434,8 +434,7 @@ static void do_change_vnc(const char *target) if (strcmp(target, "passwd") == 0 || strcmp(target, "password") == 0) { char password[9]; - monitor_readline("Password: ", 1, password, sizeof(password)-1); - password[sizeof(password)-1] = '\0'; + monitor_readline("Password: ", 1, password, sizeof(password)); if (vnc_display_password(NULL, password) < 0) term_printf("could not set VNC server password\n"); } else { -- 2.7.4