From dced7b85efed67dfaff6e584dccbbb5cde29912c Mon Sep 17 00:00:00 2001 From: Stefan Schmidt Date: Tue, 9 Jun 2020 14:29:35 +0200 Subject: [PATCH] tests: evas: check fd being non -1 before using close() eina_file_mkstemp would return -1 in an error case. Make sure we check the return when clsoing here. CID: 1400790 Reviewed-by: Christopher Michael Differential Revision: https://phab.enlightenment.org/D11957 --- src/tests/evas/evas_test_image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tests/evas/evas_test_image.c b/src/tests/evas/evas_test_image.c index 7ee1604..8106a08 100644 --- a/src/tests/evas/evas_test_image.c +++ b/src/tests/evas/evas_test_image.c @@ -904,7 +904,8 @@ EFL_START_TEST(evas_object_image_map_unmap) // save file, verify its pixels fd = eina_file_mkstemp("/tmp/evas-test.XXXXXX.png", &tmp); - close(fd); + fail_if(fd <= 0); + fail_if(close(fd)); if (efl_file_save(o, tmp, NULL, NULL)) { Eina_Rw_Slice sorig, sdest; -- 2.7.4