From dc8fdcbb69f8f61d883c3c1a698ca6a9b4bf24b0 Mon Sep 17 00:00:00 2001 From: Erich Keane Date: Thu, 19 Mar 2015 15:16:31 -0700 Subject: [PATCH] Fixed KW Warnings based on using uninitialized values The values adjusted here were improperly initialized, so these fixes ensure that they are only used when properly initialized. Note that in the second case, we were checking for NULL, but dereferencing anyway. This adds an else case to avoid that. Change-Id: I34cb292267f6ba21d3849fa5ad06b89eca02b557 Signed-off-by: Erich Keane Reviewed-on: https://gerrit.iotivity.org/gerrit/519 Tested-by: jenkins-iotivity Reviewed-by: Mandeep Shetty Reviewed-by: Sashi Penta --- resource/csdk/stack/src/ocstack.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/resource/csdk/stack/src/ocstack.c b/resource/csdk/stack/src/ocstack.c index a77f80a..c859a15 100644 --- a/resource/csdk/stack/src/ocstack.c +++ b/resource/csdk/stack/src/ocstack.c @@ -342,7 +342,7 @@ OCStackResult UpdateResponseAddr(OCClientResponse *response, const CARemoteEndpo address.addr[i] = atoi(tok); } - memcpy(&address.addr[4], &endPoint->addressInfo.IP.port, sizeof(uint32_t)); + memcpy(&address.addr[4], &endPoint->addressInfo.IP.port, sizeof(endPoint->addressInfo.IP.port)); if(response) { @@ -417,7 +417,7 @@ OCStackResult HandlePresenceResponse(const CARemoteEndpoint_t* endPoint, OCStackApplicationResult cbResult = OC_STACK_DELETE_TRANSACTION; ClientCB * cbNode = NULL; char *resourceTypeName = NULL; - OCClientResponse response; + OCClientResponse response = {0}; OCStackResult result = OC_STACK_ERROR; uint32_t lowerBound = 0; uint32_t higherBound = 0; @@ -3504,7 +3504,6 @@ OCStackResult getResourceType(const char * query, char** resourceType) { result = OC_STACK_NO_MEMORY; } - strcpy((char *)*resourceType, ((const char *)&query[3])); result = OC_STACK_OK; } -- 2.7.4