From dba7455e76f87abe81cc9e4e9b1f979c1da02846 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 29 Jul 2018 15:23:51 -0600 Subject: [PATCH] Remove old lint code This removes dead code that, according to the comments, existed to placate lint. I don't think this has been relevant in a long time, and certainly not since gdb switched to C++. Tested by rebuilding. ChangeLog 2018-07-30 Tom Tromey * cli/cli-decode.c (lookup_cmd): Remove lint code. * value.c (unpack_long): Remove lint code. * valops.c (value_ind): Remove lint code. * valarith.c (value_x_binop, value_x_unop, value_equal) (value_pos): Remove lint code. --- gdb/ChangeLog | 8 ++++++++ gdb/cli/cli-decode.c | 1 - gdb/valarith.c | 20 +++----------------- gdb/valops.c | 1 - gdb/value.c | 1 - 5 files changed, 11 insertions(+), 20 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2c2763d..2cd7d64 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2018-07-30 Tom Tromey + + * cli/cli-decode.c (lookup_cmd): Remove lint code. + * value.c (unpack_long): Remove lint code. + * valops.c (value_ind): Remove lint code. + * valarith.c (value_x_binop, value_x_unop, value_equal) + (value_pos): Remove lint code. + 2018-07-28 Tom de Vries * eval.c (evaluate_subexp_for_sizeof): Interpret size of dynamic type diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index c8dda70..83dd67e 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -1561,7 +1561,6 @@ lookup_cmd (const char **line, struct cmd_list_element *list, } error (_("Ambiguous %scommand \"%s\": %s."), local_cmdtype, *line, ambbuf); - return 0; /* lint */ } } else diff --git a/gdb/valarith.c b/gdb/valarith.c index d2dd590..01ca50d 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -504,9 +504,6 @@ value_x_binop (struct value *arg1, struct value *arg2, enum exp_opcode op, } throw_error (NOT_FOUND_ERROR, _("member function %s not found"), tstr); -#ifdef lint - return call_function_by_hand (argvec[0], 2 - static_memfuncp, argvec + 1); -#endif } /* We know that arg1 is a structure, so try to find a unary user @@ -622,8 +619,6 @@ value_x_unop (struct value *arg1, enum exp_opcode op, enum noside noside) } throw_error (NOT_FOUND_ERROR, _("member function %s not found"), tstr); - - return 0; /* For lint -- never reached */ } @@ -1533,10 +1528,7 @@ value_equal (struct value *arg1, struct value *arg2) return value_strcmp (arg1, arg2) == 0; } else - { - error (_("Invalid type combination in equality test.")); - return 0; /* For lint -- never reached. */ - } + error (_("Invalid type combination in equality test.")); } /* Compare values based on their raw contents. Useful for arrays since @@ -1628,10 +1620,7 @@ value_pos (struct value *arg1) || (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type))) return value_from_contents (type, value_contents (arg1)); else - { - error (_("Argument to positive operation not a number.")); - return 0; /* For lint -- never reached. */ - } + error (_("Argument to positive operation not a number.")); } struct value * @@ -1663,10 +1652,7 @@ value_neg (struct value *arg1) return val; } else - { - error (_("Argument to negate operation not a number.")); - return 0; /* For lint -- never reached. */ - } + error (_("Argument to negate operation not a number.")); } struct value * diff --git a/gdb/valops.c b/gdb/valops.c index 9bdbf22..de6f839 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1588,7 +1588,6 @@ value_ind (struct value *arg1) } error (_("Attempt to take contents of a non-pointer value.")); - return 0; /* For lint -- never reached. */ } /* Create a value for an array by allocating space in GDB, copying the diff --git a/gdb/value.c b/gdb/value.c index af635ba..b0f22f1 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -2777,7 +2777,6 @@ unpack_long (struct type *type, const gdb_byte *valaddr) default: error (_("Value can't be converted to integer.")); } - return 0; /* Placate lint. */ } /* Unpack raw data (copied from debugee, target byte order) at VALADDR -- 2.7.4