From dab879d7c805562debea149e6d2c17839405c71b Mon Sep 17 00:00:00 2001 From: Antonio Afonso Date: Mon, 3 Jun 2019 15:18:15 +0000 Subject: [PATCH] [lldb-server unittest] Add missing teardown logic Summary: This test base class is missing the teardown making the second set of tests extending it to fail in an assertion in the FileSystem::Initialize() (as it's being initialized twice). Not sure why this isn't failing the build bots.. (unless they're running without asserts?). With this fix `ninja LLDBServerTests && ./tools/lldb/unittests/tools/lldb-server/tests/LLDBServerTests` successfully runs and passes all tests. Reviewers: clayborg, xiaobai, labath Reviewed By: xiaobai, labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D62788 llvm-svn: 362406 --- lldb/unittests/tools/lldb-server/tests/TestBase.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lldb/unittests/tools/lldb-server/tests/TestBase.h b/lldb/unittests/tools/lldb-server/tests/TestBase.h index 76ff96a..053ee8f 100644 --- a/lldb/unittests/tools/lldb-server/tests/TestBase.h +++ b/lldb/unittests/tools/lldb-server/tests/TestBase.h @@ -25,6 +25,11 @@ public: lldb_private::HostInfo::Initialize(); } + static void TearDownTestCase() { + lldb_private::HostInfo::Terminate(); + lldb_private::FileSystem::Terminate(); + } + static std::string getInferiorPath(llvm::StringRef Name) { llvm::SmallString<64> Path(LLDB_TEST_INFERIOR_PATH); llvm::sys::path::append(Path, Name + LLDB_TEST_INFERIOR_SUFFIX); -- 2.7.4