From da5f91b3b3381c282207ba113d42b293b0331c9d Mon Sep 17 00:00:00 2001 From: Juerg Billeter Date: Mon, 24 Mar 2008 20:37:30 +0000 Subject: [PATCH] fix crash on invalid collection expressions in foreach statements, fixes 2008-03-24 Juerg Billeter * vala/valasemanticanalyzer.vala: fix crash on invalid collection expressions in foreach statements, fixes bug 524033 svn path=/trunk/; revision=1160 --- ChangeLog | 5 +++++ vala/valasemanticanalyzer.vala | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/ChangeLog b/ChangeLog index 5d44bf9..65b4175 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,10 @@ 2008-03-24 Jürg Billeter + * vala/valasemanticanalyzer.vala: fix crash on invalid collection + expressions in foreach statements, fixes bug 524033 + +2008-03-24 Jürg Billeter + * vapi/sdl.vapi: add missing public modifier, patch by Levi Bard, fixes bug 524192 diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala index 45257a0..8d144d3 100644 --- a/vala/valasemanticanalyzer.vala +++ b/vala/valasemanticanalyzer.vala @@ -992,6 +992,10 @@ public class Vala.SemanticAnalyzer : CodeVisitor { // ignore inner error stmt.error = true; return; + } else if (stmt.collection.static_type == null) { + Report.error (stmt.collection.source_reference, "invalid collection expression"); + stmt.error = true; + return; } stmt.collection_variable_declarator = new VariableDeclarator ("%s_collection".printf (stmt.variable_name)); -- 2.7.4