From da47c7ccb90d49ef4864304492a5866f361d556c Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 29 Aug 2022 11:09:54 +0000 Subject: [PATCH] Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp (NFC) --- mlir/include/mlir/Dialect/SCF/Utils/Utils.h | 2 +- mlir/lib/Dialect/SCF/Utils/Utils.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mlir/include/mlir/Dialect/SCF/Utils/Utils.h b/mlir/include/mlir/Dialect/SCF/Utils/Utils.h index 478dd4f..63b94a1 100644 --- a/mlir/include/mlir/Dialect/SCF/Utils/Utils.h +++ b/mlir/include/mlir/Dialect/SCF/Utils/Utils.h @@ -69,7 +69,7 @@ scf::ForOp replaceLoopWithNewYields(OpBuilder &builder, scf::ForOp loop, SmallVector replaceLoopNestWithNewYields(OpBuilder &builder, ArrayRef loopNest, ValueRange newIterOperands, - NewYieldValueFn newYieldValueFn); + const NewYieldValueFn &newYieldValueFn); /// Outline a region with a single block into a new FuncOp. /// Assumes the FuncOp result types is the type of the yielded operands of the diff --git a/mlir/lib/Dialect/SCF/Utils/Utils.cpp b/mlir/lib/Dialect/SCF/Utils/Utils.cpp index 24b92d6..e40fc9c 100644 --- a/mlir/lib/Dialect/SCF/Utils/Utils.cpp +++ b/mlir/lib/Dialect/SCF/Utils/Utils.cpp @@ -104,7 +104,7 @@ mlir::replaceLoopWithNewYields(OpBuilder &builder, scf::ForOp loop, SmallVector mlir::replaceLoopNestWithNewYields( OpBuilder &builder, ArrayRef loopNest, - ValueRange newIterOperands, NewYieldValueFn newYieldValueFn) { + ValueRange newIterOperands, const NewYieldValueFn &newYieldValueFn) { if (loopNest.empty()) return {}; SmallVector newLoopNest(loopNest.size()); -- 2.7.4