From d9f702918cb55802519aa19ff6aa64a554d1dec4 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Mon, 25 May 2015 17:04:56 +1000 Subject: [PATCH] test: fail if fgets() from addr2line returns NULL Found by Coverity Signed-off-by: Peter Hutterer --- test/litest.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/litest.c b/test/litest.c index 037186f3..7a4938da 100644 --- a/test/litest.c +++ b/test/litest.c @@ -99,7 +99,10 @@ litest_backtrace_get_lineno(const char *executable, } buffer[0] = '?'; - fgets(buffer, sizeof(buffer), f); + if (fgets(buffer, sizeof(buffer), f) == NULL) { + pclose(f); + return false; + } pclose(f); if (buffer[0] == '?') -- 2.34.1