From d97fca12e92d3179554baf4db42611e5fe56aeed Mon Sep 17 00:00:00 2001 From: Alex Elder Date: Tue, 24 May 2016 13:34:50 -0500 Subject: [PATCH] greybus: fix pointless null check Coccinelle points out that a call in gb_lights_channel_free() to flush_work() is passed which is always non-null. Prior to the call, there is an unnecessary check to see if that address is null. Get rid of the test. Signed-off-by: Alex Elder Reviewed-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/light.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8b71ed3..78fb8a9 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1019,8 +1019,7 @@ static int gb_lights_light_register(struct gb_light *light) static void gb_lights_channel_free(struct gb_channel *channel) { #ifndef LED_HAVE_SET_BLOCKING - if (&channel->work_brightness_set) - flush_work(&channel->work_brightness_set); + flush_work(&channel->work_brightness_set); #endif kfree(channel->attrs); kfree(channel->attr_group); -- 2.7.4