From d93735c280e2f4d4444d4b385eca3fe9f3677761 Mon Sep 17 00:00:00 2001 From: Mike Danes Date: Sat, 19 Aug 2017 11:59:24 +0300 Subject: [PATCH] Fix incorrect switch temp lcl type --- src/jit/lower.cpp | 4 +-- .../JitBlue/GitHub_13486/GitHub_13486.cs | 33 ++++++++++++++++++++++ .../JitBlue/GitHub_13486/GitHub_13486.csproj | 25 ++++++++++++++++ 3 files changed, 60 insertions(+), 2 deletions(-) create mode 100644 tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.cs create mode 100644 tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.csproj diff --git a/src/jit/lower.cpp b/src/jit/lower.cpp index f40c4aa..6c06480 100644 --- a/src/jit/lower.cpp +++ b/src/jit/lower.cpp @@ -518,7 +518,7 @@ GenTree* Lowering::LowerSwitch(GenTree* node) assert(temp->gtOper == GT_LCL_VAR); unsigned tempLclNum = temp->gtLclVarCommon.gtLclNum; LclVarDsc* tempVarDsc = comp->lvaTable + tempLclNum; - var_types tempLclType = tempVarDsc->TypeGet(); + var_types tempLclType = temp->TypeGet(); BasicBlock* defaultBB = jumpTab[jumpCnt - 1]; BasicBlock* followingBB = originalSwitchBB->bbNext; @@ -548,7 +548,7 @@ GenTree* Lowering::LowerSwitch(GenTree* node) // both GT_SWITCH lowering code paths. // This condition is of the form: if (temp > jumpTableLength - 2){ goto jumpTable[jumpTableLength - 1]; } GenTreePtr gtDefaultCaseCond = comp->gtNewOperNode(GT_GT, TYP_INT, comp->gtNewLclvNode(tempLclNum, tempLclType), - comp->gtNewIconNode(jumpCnt - 2, tempLclType)); + comp->gtNewIconNode(jumpCnt - 2, genActualType(tempLclType))); // Make sure we perform an unsigned comparison, just in case the switch index in 'temp' // is now less than zero 0 (that would also hit the default case). diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.cs b/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.cs new file mode 100644 index 0000000..cb4bd4e --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.cs @@ -0,0 +1,33 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +using System; +using System.Runtime.CompilerServices; + +class Program +{ + enum LongEnum : long + { + Option0, Option1, Option2 + } + + [MethodImpl(MethodImplOptions.NoInlining)] + static string Test(LongEnum v) + { + string s; + switch (v) + { + case LongEnum.Option0: s = "Option0"; break; + case LongEnum.Option1: s = "Option1"; break; + case LongEnum.Option2: s = "Option2"; break; + default: throw new Exception(); + } + return s; + } + + static int Main() + { + return (Test(LongEnum.Option0) == "Option0") ? 100 : 1; + } +} diff --git a/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.csproj b/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.csproj new file mode 100644 index 0000000..4bf984a --- /dev/null +++ b/tests/src/JIT/Regression/JitBlue/GitHub_13486/GitHub_13486.csproj @@ -0,0 +1,25 @@ + + + + + Debug + AnyCPU + $(MSBuildProjectName) + {95DFC527-4DC1-495E-97D7-E94EE1F7140D} + Exe + {786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} + ..\..\ + + + + + + + + False + + + + + + -- 2.7.4