From d913a243196fa07d4728c8f7c1ce6444ecd086eb Mon Sep 17 00:00:00 2001 From: Justin Lebar Date: Mon, 21 May 2018 17:34:56 -0700 Subject: [PATCH] [XLA] Two minor style-guide fixups. - Fix TODO(b/123) style. - Use a value type rather than an rvalue reference for a "sink" param. PiperOrigin-RevId: 197489597 --- tensorflow/compiler/xla/service/gpu/sequential_thunk.cc | 2 +- tensorflow/compiler/xla/service/gpu/sequential_thunk.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow/compiler/xla/service/gpu/sequential_thunk.cc b/tensorflow/compiler/xla/service/gpu/sequential_thunk.cc index b50f5b5..88cb108 100644 --- a/tensorflow/compiler/xla/service/gpu/sequential_thunk.cc +++ b/tensorflow/compiler/xla/service/gpu/sequential_thunk.cc @@ -20,7 +20,7 @@ limitations under the License. namespace xla { namespace gpu { -SequentialThunk::SequentialThunk(std::vector>&& thunks, +SequentialThunk::SequentialThunk(std::vector> thunks, const HloInstruction* hlo) : Thunk(Kind::kSequential, hlo), thunks_(std::move(thunks)) {} diff --git a/tensorflow/compiler/xla/service/gpu/sequential_thunk.h b/tensorflow/compiler/xla/service/gpu/sequential_thunk.h index 3537110..135f79e 100644 --- a/tensorflow/compiler/xla/service/gpu/sequential_thunk.h +++ b/tensorflow/compiler/xla/service/gpu/sequential_thunk.h @@ -31,7 +31,7 @@ namespace gpu { // require multiple kernel launches or library calls. class SequentialThunk : public Thunk { public: - SequentialThunk(std::vector>&& thunks, + SequentialThunk(std::vector> thunks, const HloInstruction* hlo); SequentialThunk(const SequentialThunk&) = delete; SequentialThunk& operator=(const SequentialThunk&) = delete; -- 2.7.4