From d86aba27cef7849f41cae3be09585d05ba8348ff Mon Sep 17 00:00:00 2001 From: Ravi Kiran K N Date: Wed, 29 Oct 2014 16:26:07 +0530 Subject: [PATCH] tests/playback: correct state change checking Correct the test apps check if result of state change is not failure as the state change can happen async https://bugzilla.gnome.org/show_bug.cgi?id=739346 --- tests/icles/playback/test2.c | 2 +- tests/icles/playback/test4.c | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/icles/playback/test2.c b/tests/icles/playback/test2.c index 28f62e5..9801ae0 100644 --- a/tests/icles/playback/test2.c +++ b/tests/icles/playback/test2.c @@ -32,7 +32,7 @@ main (gint argc, gchar * argv[]) g_object_set (G_OBJECT (player), "uri", argv[1], NULL); res = gst_element_set_state (player, GST_STATE_PLAYING); - if (res != GST_STATE_CHANGE_SUCCESS) { + if (res == GST_STATE_CHANGE_FAILURE) { g_print ("could not play\n"); return -1; } diff --git a/tests/icles/playback/test4.c b/tests/icles/playback/test4.c index 8fdeb3f..410bacf 100644 --- a/tests/icles/playback/test4.c +++ b/tests/icles/playback/test4.c @@ -48,7 +48,7 @@ main (gint argc, gchar * argv[]) g_print ("play...\n"); res = gst_element_set_state (player, GST_STATE_PLAYING); - if (res != GST_STATE_CHANGE_SUCCESS) { + if (res == GST_STATE_CHANGE_FAILURE) { g_print ("could not play\n"); return -1; } @@ -58,8 +58,8 @@ main (gint argc, gchar * argv[]) g_print ("pause...\n"); res = gst_element_set_state (player, GST_STATE_PAUSED); - if (res != GST_STATE_CHANGE_SUCCESS) { - g_print ("could not play\n"); + if (res == GST_STATE_CHANGE_FAILURE) { + g_print ("could not pause\n"); return -1; } @@ -68,7 +68,7 @@ main (gint argc, gchar * argv[]) g_print ("play...\n"); res = gst_element_set_state (player, GST_STATE_PLAYING); - if (res != GST_STATE_CHANGE_SUCCESS) { + if (res == GST_STATE_CHANGE_FAILURE) { g_print ("could not play\n"); return -1; } @@ -88,7 +88,7 @@ main (gint argc, gchar * argv[]) g_print ("play...\n"); res = gst_element_set_state (player, GST_STATE_PLAYING); - if (res != GST_STATE_CHANGE_SUCCESS) { + if (res == GST_STATE_CHANGE_FAILURE) { g_print ("could not play\n"); return -1; } -- 2.7.4