From d8326ceafbd8903b69e211ec6449ecdb83efc761 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Fri, 9 Oct 2020 14:00:28 +0200 Subject: [PATCH] panfrost: Fix fixed-function blend on bifrost The conversion from a 32b float to a 16b fixed-point number was wrong. Fixes: 8389976b7c09 ("panfrost: XML-ify the blend descriptors") Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index 52f3abc..e95e414 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -311,7 +311,7 @@ panfrost_emit_bifrost_blend(struct panfrost_batch *batch, cfg.bifrost.equation = blend[i].equation.equation; /* Fixed point constant */ - u16 constant = blend[i].equation.constant / ((1 << chan_size) - 1); + u16 constant = blend[i].equation.constant * ((1 << chan_size) - 1); constant <<= 16 - chan_size; cfg.bifrost.constant = constant; -- 2.7.4