From d831d955f68cffbfa7a3a9027535f5f994655b77 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Fri, 8 Mar 2013 22:15:15 +0000 Subject: [PATCH] Don't try to wire up typedef names for invalid anonymous tag declarations encountered during template instantiation. llvm-svn: 176727 --- clang/lib/Sema/SemaTemplateInstantiateDecl.cpp | 2 +- clang/test/SemaTemplate/instantiate-type.cpp | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp index d54ca31..c39f006 100644 --- a/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ b/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -229,7 +229,7 @@ Decl *TemplateDeclInstantiator::InstantiateTypedefNameDecl(TypedefNameDecl *D, // tag decl, re-establish that relationship for the new typedef. if (const TagType *oldTagType = D->getUnderlyingType()->getAs()) { TagDecl *oldTag = oldTagType->getDecl(); - if (oldTag->getTypedefNameForAnonDecl() == D) { + if (oldTag->getTypedefNameForAnonDecl() == D && !Invalid) { TagDecl *newTag = DI->getType()->castAs()->getDecl(); assert(!newTag->getIdentifier() && !newTag->getTypedefNameForAnonDecl()); newTag->setTypedefNameForAnonDecl(Typedef); diff --git a/clang/test/SemaTemplate/instantiate-type.cpp b/clang/test/SemaTemplate/instantiate-type.cpp index f5d02707..2440a38 100644 --- a/clang/test/SemaTemplate/instantiate-type.cpp +++ b/clang/test/SemaTemplate/instantiate-type.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only %s +// RUN: %clang_cc1 -fsyntax-only -verify %s int* f(int); float *f(...); @@ -15,3 +15,14 @@ X::typeof_type &iptr1 = iptr0; X::typeof_expr &iptr2 = iptr0; X::typeof_expr &fptr1 = fptr0; + +namespace rdar13094134 { + template + class X { + typedef struct { + Y *y; // expected-error{{unknown type name 'Y'}} + } Y; + }; + + X xi; +} -- 2.7.4