From d78b9a5adaf7f0c875caab3145a1b6ae6acd18df Mon Sep 17 00:00:00 2001 From: =?utf8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 24 Jun 2015 10:52:02 +0200 Subject: [PATCH] bufferlist: Warn if copying a buffer fails in gst_buffer_list_copy_deep() --- gst/gstbufferlist.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gst/gstbufferlist.c b/gst/gstbufferlist.c index 2ae3f2f..dabcd6a 100644 --- a/gst/gstbufferlist.c +++ b/gst/gstbufferlist.c @@ -389,7 +389,16 @@ gst_buffer_list_copy_deep (const GstBufferList * list) len = list->n_buffers; for (i = 0; i < len; i++) { GstBuffer *old = list->buffers[i]; - gst_buffer_list_insert (result, i, gst_buffer_copy_deep (old)); + GstBuffer *new = gst_buffer_copy_deep (old); + + if (G_LIKELY (new)) { + gst_buffer_list_insert (result, i, new); + } else { + g_warning + ("Failed to deep copy buffer %p while deep " + "copying buffer list %p. Buffer list copy " + "will be incomplete", old, list); + } } return result; -- 2.7.4