From d75303581f0cb932024e4e4cda34cab3209927b0 Mon Sep 17 00:00:00 2001 From: Enrico Granata Date: Wed, 23 Jul 2014 18:18:38 +0000 Subject: [PATCH] Ensure that if some unspecified person were to pass in an invalid architecture when trying to create a target, that it would fail, but not cause LLDB to crash. llvm-svn: 213781 --- lldb/test/functionalities/nosucharch/Makefile | 5 +++ .../functionalities/nosucharch/TestNoSuchArch.py | 48 ++++++++++++++++++++++ lldb/test/functionalities/nosucharch/main.cpp | 3 ++ 3 files changed, 56 insertions(+) create mode 100644 lldb/test/functionalities/nosucharch/Makefile create mode 100644 lldb/test/functionalities/nosucharch/TestNoSuchArch.py create mode 100644 lldb/test/functionalities/nosucharch/main.cpp diff --git a/lldb/test/functionalities/nosucharch/Makefile b/lldb/test/functionalities/nosucharch/Makefile new file mode 100644 index 0000000..8a7102e --- /dev/null +++ b/lldb/test/functionalities/nosucharch/Makefile @@ -0,0 +1,5 @@ +LEVEL = ../../make + +CXX_SOURCES := main.cpp + +include $(LEVEL)/Makefile.rules diff --git a/lldb/test/functionalities/nosucharch/TestNoSuchArch.py b/lldb/test/functionalities/nosucharch/TestNoSuchArch.py new file mode 100644 index 0000000..bba3ab6 --- /dev/null +++ b/lldb/test/functionalities/nosucharch/TestNoSuchArch.py @@ -0,0 +1,48 @@ +""" +Test that using a non-existent architecture name does not crash LLDB. +""" +import lldb +import unittest2 +from lldbtest import * +import lldbutil + +class NoSuchArchTestCase(TestBase): + + mydir = TestBase.compute_mydir(__file__) + + + @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") + @dsym_test + def test_with_dsym (self): + self.buildDsym() + self.do_test () + + + @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") + @dwarf_test + def test_with_dwarf (self): + self.buildDwarf() + self.do_test () + + def do_test (self): + exe = os.path.join (os.getcwd(), "a.out") + + # Check that passing an invalid arch via the command-line fails but doesn't crash + self.expect("target crete --arch nothingtoseehere %s" % (exe), error=True) + + + # Check that passing an invalid arch via the SB API fails but doesn't crash + target = self.dbg.CreateTargetWithFileAndArch(exe,"nothingtoseehere") + + self.assertFalse(target.IsValid(), "This target should not be valid") + + # Now just create the target with the default arch and check it's fine + target = self.dbg.CreateTarget(exe) + self.assertTrue(target.IsValid(), "This target should now be valid") + +if __name__ == '__main__': + import atexit + lldb.SBDebugger.Initialize() + atexit.register(lambda: lldb.SBDebugger.Terminate()) + unittest2.main() + diff --git a/lldb/test/functionalities/nosucharch/main.cpp b/lldb/test/functionalities/nosucharch/main.cpp new file mode 100644 index 0000000..4cce7f6 --- /dev/null +++ b/lldb/test/functionalities/nosucharch/main.cpp @@ -0,0 +1,3 @@ +int main() { + return 0; +} -- 2.7.4