From d7131e3c2cb34add3388533bbba83422ebb760db Mon Sep 17 00:00:00 2001 From: Ryuan Choi Date: Tue, 24 Sep 2013 20:30:34 +0900 Subject: [PATCH] Number input type design modification [Title] Number input type design modification [Issue#] N/A [Problem] Too hard to control buttons of Spinner [Cause] Automatic zoom service bothers to click the inner buttons exactly [Solution] Remove InnerSpinButtons and allow to type in Change-Id: I6c64bd7d76f8dcd4bd0c8ed2c3bb200d8fbb2ced --- Source/WTF/wtf/Platform.h | 1 + Source/WebCore/platform/efl/RenderThemeEfl.cpp | 4 ++-- Source/WebCore/platform/efl/RenderThemeEfl.h | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h index 7e48cea..d2759e0 100644 --- a/Source/WTF/wtf/Platform.h +++ b/Source/WTF/wtf/Platform.h @@ -632,6 +632,7 @@ com) : Patch to do not adjust cover rect as fixed pixel size*/ #define ENABLE_TIZEN_SOUP_COOKIE_CACHE_FOR_WEBKIT2 1 /* Jongseok Yang(js45.yang@samsung.com) : Implement soup cache, cookie */ #define ENABLE_TIZEN_WEBKIT2_THEME_SET_INTERNAL 1 /* Ryuan Choi(ryuan.choi@samsung.com) : Set to default theme for WK2/tizen */ +#define ENABLE_TIZEN_INPUTTYPE_NUMBER 1 /* Eunsol Cha(e.cha@samsung.com) : customize InnerSpinButtonStyle */ #define ENABLE_TIZEN_WEBKIT2_PROXY 1 /* Ryuan Choi(ryuan.choi@samsung.com) : Provide API to set proxy */ #define ENABLE_TIZEN_WEBKIT2_POPUP_INTERNAL 1 /* Ryuan Choi(ryuan.choi@samsung.com) : popup implementation for WK2/tizen internal */ #define ENABLE_TIZEN_WEBKIT2_NOTIFY_POPUP_REPLY_STATUS 1 /* Byungwoo Lee(bw80.lee@samsung.com) : Notify popup reply status through the smart callback */ diff --git a/Source/WebCore/platform/efl/RenderThemeEfl.cpp b/Source/WebCore/platform/efl/RenderThemeEfl.cpp index 37d231c..0046419 100755 --- a/Source/WebCore/platform/efl/RenderThemeEfl.cpp +++ b/Source/WebCore/platform/efl/RenderThemeEfl.cpp @@ -1105,7 +1105,7 @@ bool RenderThemeEfl::paintSearchField(RenderObject* object, const PaintInfo& inf { return paintThemePart(object, SearchField, info, rect); } - +#if !ENABLE(TIZEN_INPUTTYPE_NUMBER) void RenderThemeEfl::adjustInnerSpinButtonStyle(StyleResolver* styleResolver, RenderStyle* style, Element* element) const { if (!m_page && element && element->document()->page()) { @@ -1119,7 +1119,7 @@ bool RenderThemeEfl::paintInnerSpinButton(RenderObject* object, const PaintInfo& { return paintThemePart(object, Spinner, info, rect); } - +#endif void RenderThemeEfl::setDefaultFontSize(int size) { defaultFontSize = size; diff --git a/Source/WebCore/platform/efl/RenderThemeEfl.h b/Source/WebCore/platform/efl/RenderThemeEfl.h index dea0165..a51aff9 100644 --- a/Source/WebCore/platform/efl/RenderThemeEfl.h +++ b/Source/WebCore/platform/efl/RenderThemeEfl.h @@ -172,10 +172,10 @@ public: #endif virtual bool paintSliderThumb(RenderObject*, const PaintInfo&, const IntRect&); - +#if !ENABLE(TIZEN_INPUTTYPE_NUMBER) virtual void adjustInnerSpinButtonStyle(StyleResolver*, RenderStyle*, Element*) const; virtual bool paintInnerSpinButton(RenderObject*, const PaintInfo&, const IntRect&); - +#endif static void setDefaultFontSize(int fontsize); #if ENABLE(PROGRESS_ELEMENT) -- 2.7.4