From d6ae29832e5c0ed2c63d90db58f54ad5a1b9df20 Mon Sep 17 00:00:00 2001 From: Ilho Kim Date: Mon, 29 Jan 2024 17:46:32 +0900 Subject: [PATCH] Fix static analysis issue Fix uninitialized member variable Use of auto that causes a copy Change-Id: I82802ced0e02ca4db7473f929323b28ae4f4d2c4 Signed-off-by: Ilho Kim --- src/pkg_upgrade/src/db_upgrader.cc | 2 +- src/pkg_upgrade/src/pkg_upgrader.cc | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pkg_upgrade/src/db_upgrader.cc b/src/pkg_upgrade/src/db_upgrader.cc index ef8c931..e216ce6 100644 --- a/src/pkg_upgrade/src/db_upgrader.cc +++ b/src/pkg_upgrade/src/db_upgrader.cc @@ -60,7 +60,7 @@ bool DbUpgrader::Upgrade() { bool DbUpgrader::SetRwPkg(const std::string& pkgid) { try { Database database(kDbPath, SQLITE_OPEN_READWRITE); - auto q = Database::Sql(kSetRwPkgQuery).Bind(pkgid); + auto q = std::move(Database::Sql(kSetRwPkgQuery).Bind(pkgid)); auto guard = database.CreateTransactionGuard(); auto r = database.Exec(q); if (!r) { diff --git a/src/pkg_upgrade/src/pkg_upgrader.cc b/src/pkg_upgrade/src/pkg_upgrader.cc index 9bc2cbd..72f4706 100644 --- a/src/pkg_upgrade/src/pkg_upgrader.cc +++ b/src/pkg_upgrade/src/pkg_upgrader.cc @@ -23,7 +23,8 @@ namespace common_fota { PkgUpgrader::PkgUpgrader(const PkgContext& context, PkgOperation pkg_op) - : type_(context.GetType()), loc_(context.GetLocation()), op_(pkg_op), + : result_(PkgUpgradeResult::UNKNOWN), type_(context.GetType()), + loc_(context.GetLocation()), op_(pkg_op), id_(context.GetId()), version_(context.GetVersion()), backend_(context.GetId(), context.GetType(), context.GetLocation(), pkg_op, context.IsRemovable()) { -- 2.34.1