From d69917ecca8a8600246c9bcdd6652897f386fb1a Mon Sep 17 00:00:00 2001 From: =?utf8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Fri, 20 May 2016 19:33:39 +0200 Subject: [PATCH] remove spurious gst_video_info_init() gst_video_info_set_format() and gst_video_info_from_caps() call, internally, gst_video_info_init(), hence it is not required to call it before them. This patch removes these spurious calls. --- gst-libs/gst/vaapi/gstvaapisurface_drm.c | 1 - gst/vaapi/gstvaapipluginbase.c | 2 -- gst/vaapi/gstvaapipostproc.c | 1 - tests/simple-encoder.c | 1 - 4 files changed, 5 deletions(-) diff --git a/gst-libs/gst/vaapi/gstvaapisurface_drm.c b/gst-libs/gst/vaapi/gstvaapisurface_drm.c index 426019a..371f05d 100644 --- a/gst-libs/gst/vaapi/gstvaapisurface_drm.c +++ b/gst-libs/gst/vaapi/gstvaapisurface_drm.c @@ -114,7 +114,6 @@ fill_video_info (GstVideoInfo * vip, GstVideoFormat format, guint width, { guint i; - gst_video_info_init (vip); gst_video_info_set_format (vip, format, width, height); for (i = 0; i < GST_VIDEO_INFO_N_PLANES (vip); i++) { GST_VIDEO_INFO_PLANE_OFFSET (vip, i) = offset[i]; diff --git a/gst/vaapi/gstvaapipluginbase.c b/gst/vaapi/gstvaapipluginbase.c index 45e9a3d..8ef550c 100644 --- a/gst/vaapi/gstvaapipluginbase.c +++ b/gst/vaapi/gstvaapipluginbase.c @@ -500,7 +500,6 @@ ensure_sinkpad_buffer_pool (GstVaapiPluginBase * plugin, GstCaps * caps) if (!pool) goto error_create_pool; - gst_video_info_init (&vi); gst_video_info_from_caps (&vi, caps); if (GST_VIDEO_INFO_FORMAT (&vi) == GST_VIDEO_FORMAT_ENCODED) { GST_DEBUG ("assume video buffer pool format is NV12"); @@ -694,7 +693,6 @@ gst_vaapi_plugin_base_decide_allocation (GstVaapiPluginBase * plugin, if (!gst_vaapi_plugin_base_ensure_display (plugin)) goto error_ensure_display; - gst_video_info_init (&vi); gst_video_info_from_caps (&vi, caps); if (GST_VIDEO_INFO_FORMAT (&vi) == GST_VIDEO_FORMAT_ENCODED) gst_video_info_set_format (&vi, GST_VIDEO_FORMAT_NV12, diff --git a/gst/vaapi/gstvaapipostproc.c b/gst/vaapi/gstvaapipostproc.c index a29b2a6..85270c6 100644 --- a/gst/vaapi/gstvaapipostproc.c +++ b/gst/vaapi/gstvaapipostproc.c @@ -1140,7 +1140,6 @@ ensure_srcpad_buffer_pool (GstVaapiPostproc * postproc, GstCaps * caps) GstVideoInfo vi; GstVaapiVideoPool *pool; - gst_video_info_init (&vi); gst_video_info_from_caps (&vi, caps); gst_video_info_change_format (&vi, postproc->format, GST_VIDEO_INFO_WIDTH (&vi), GST_VIDEO_INFO_HEIGHT (&vi)); diff --git a/tests/simple-encoder.c b/tests/simple-encoder.c index b827604..58b0e8c 100644 --- a/tests/simple-encoder.c +++ b/tests/simple-encoder.c @@ -157,7 +157,6 @@ new_codec_state (gint width, gint height, gint fps_n, gint fps_d) state = g_slice_new0 (GstVideoCodecState); state->ref_count = 1; - gst_video_info_init (&state->info); gst_video_info_set_format (&state->info, GST_VIDEO_FORMAT_ENCODED, width, height); -- 2.7.4