From d696f7b3c1259d1ca2a3d34856df58f164e87bbc Mon Sep 17 00:00:00 2001 From: "mstarzinger@chromium.org" Date: Wed, 22 May 2013 09:17:27 +0000 Subject: [PATCH] Use explicit type feedback clearing in some tests. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/15711004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/compiler/alloc-object.js | 4 ++-- test/mjsunit/external-array-no-sse2.js | 9 ++++----- test/mjsunit/external-array.js | 9 ++++----- test/mjsunit/fast-element-smi-check.js | 6 +++--- 4 files changed, 13 insertions(+), 15 deletions(-) diff --git a/test/mjsunit/compiler/alloc-object.js b/test/mjsunit/compiler/alloc-object.js index 1d44efb..0e593a4 100644 --- a/test/mjsunit/compiler/alloc-object.js +++ b/test/mjsunit/compiler/alloc-object.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --allow-natives-syntax --expose-gc --inline-construct +// Flags: --allow-natives-syntax --inline-construct // Test that inlined object allocation works for different layouts of // objects (e.g. in object properties, slack tracking in progress or @@ -53,7 +53,7 @@ function test(construct) { assertEquals(5, o.y); assertEquals(6, o.z); %DeoptimizeFunction(test_helper); - gc(); // Makes V8 forget about type information for test_helper. + %ClearFunctionTypeFeedback(test_helper); } function finalize_slack_tracking(construct) { diff --git a/test/mjsunit/external-array-no-sse2.js b/test/mjsunit/external-array-no-sse2.js index b3d91a5..c9d5621 100644 --- a/test/mjsunit/external-array-no-sse2.js +++ b/test/mjsunit/external-array-no-sse2.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --allow-natives-syntax --expose-gc --noenable-sse2 +// Flags: --allow-natives-syntax --noenable-sse2 // Helper function assertInstance(o, f) { @@ -301,7 +301,7 @@ function run_test(test_func, array, expected_result) { } assertEquals(expected_result, sum); %DeoptimizeFunction(test_func); - gc(); // Makes V8 forget about type information for test_func. + %ClearFunctionTypeFeedback(test_func); } function run_bounds_test(test_func, array, expected_result) { @@ -350,8 +350,7 @@ for (var t = 0; t < types.length; t++) { %OptimizeFunctionOnNextCall(run_bounds_test); run_bounds_test(a); %DeoptimizeFunction(run_bounds_test); - gc(); // Makes V8 forget about type information for test_func. - + %ClearFunctionTypeFeedback(run_bounds_test); } function array_load_set_smi_check(a) { @@ -370,7 +369,7 @@ for (var t = 0; t < types.length; t++) { array_load_set_smi_check2(a); array_load_set_smi_check2(0); %DeoptimizeFunction(array_load_set_smi_check2); - gc(); // Makes V8 forget about type information for array_load_set_smi_check. + %ClearFunctionTypeFeedback(array_load_set_smi_check2); } // Check handling of undefined in 32- and 64-bit external float arrays. diff --git a/test/mjsunit/external-array.js b/test/mjsunit/external-array.js index e61ff45..bfdab8a 100644 --- a/test/mjsunit/external-array.js +++ b/test/mjsunit/external-array.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --allow-natives-syntax --expose-gc +// Flags: --allow-natives-syntax // Helper function assertInstance(o, f) { @@ -301,7 +301,7 @@ function run_test(test_func, array, expected_result) { } assertEquals(expected_result, sum); %DeoptimizeFunction(test_func); - gc(); // Makes V8 forget about type information for test_func. + %ClearFunctionTypeFeedback(test_func); } function run_bounds_test(test_func, array, expected_result) { @@ -350,8 +350,7 @@ for (var t = 0; t < types.length; t++) { %OptimizeFunctionOnNextCall(run_bounds_test); run_bounds_test(a); %DeoptimizeFunction(run_bounds_test); - gc(); // Makes V8 forget about type information for test_func. - + %ClearFunctionTypeFeedback(run_bounds_test); } function array_load_set_smi_check(a) { @@ -370,7 +369,7 @@ for (var t = 0; t < types.length; t++) { array_load_set_smi_check2(a); array_load_set_smi_check2(0); %DeoptimizeFunction(array_load_set_smi_check2); - gc(); // Makes V8 forget about type information for array_load_set_smi_check. + %ClearFunctionTypeFeedback(array_load_set_smi_check2); } // Check handling of undefined in 32- and 64-bit external float arrays. diff --git a/test/mjsunit/fast-element-smi-check.js b/test/mjsunit/fast-element-smi-check.js index d0c45fe..3083d5f 100644 --- a/test/mjsunit/fast-element-smi-check.js +++ b/test/mjsunit/fast-element-smi-check.js @@ -25,7 +25,7 @@ // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -// Flags: --allow-natives-syntax --expose-gc +// Flags: --allow-natives-syntax var a = new Array(10); @@ -46,7 +46,7 @@ test_load_set_smi_2(a); test_load_set_smi_2(a); test_load_set_smi_2(0); %DeoptimizeFunction(test_load_set_smi_2); -gc(); // Makes V8 forget about type information for test_load_set_smi. +%ClearFunctionTypeFeedback(test_load_set_smi_2); var b = new Object(); @@ -67,4 +67,4 @@ test_load_set_smi_4(b); test_load_set_smi_4(b); test_load_set_smi_4(0); %DeoptimizeFunction(test_load_set_smi_4); -gc(); // Makes V8 forget about type information for test_load_set_smi. +%ClearFunctionTypeFeedback(test_load_set_smi_4); -- 2.7.4