From d67fa9dc6a434c5c1ff2c08a0a006d30d174d295 Mon Sep 17 00:00:00 2001 From: Matthias Braun Date: Thu, 10 Nov 2016 23:36:44 +0000 Subject: [PATCH] Timer: Remove group-less NamedRegionTimer constructor. The NamedRegionTimer initializer without a group name puts the Timer into the "Misc" group and is (nearly) unused. Remove it. The only user of this constructor appears to be the HexagonGenInsert pass, which creates a counter without group to count the complete execution time of that pass, however since every pass gets a counter by the PassManager anyway this should be unnecessary. Also removed the pointless TimerGroup there. Differential Revision: https://reviews.llvm.org/D25582 llvm-svn: 286524 --- llvm/include/llvm/Support/Timer.h | 2 -- llvm/lib/Support/Timer.cpp | 14 -------------- llvm/lib/Target/Hexagon/HexagonGenInsert.cpp | 2 -- 3 files changed, 18 deletions(-) diff --git a/llvm/include/llvm/Support/Timer.h b/llvm/include/llvm/Support/Timer.h index a0051b5..dbe2033 100644 --- a/llvm/include/llvm/Support/Timer.h +++ b/llvm/include/llvm/Support/Timer.h @@ -152,8 +152,6 @@ public: /// statement. All timers with the same name are merged. This is primarily /// used for debugging and for hunting performance problems. struct NamedRegionTimer : public TimeRegion { - explicit NamedRegionTimer(StringRef Name, - bool Enabled = true); explicit NamedRegionTimer(StringRef Name, StringRef GroupName, bool Enabled = true); }; diff --git a/llvm/lib/Support/Timer.cpp b/llvm/lib/Support/Timer.cpp index afb16ca..548f9da 100644 --- a/llvm/lib/Support/Timer.cpp +++ b/llvm/lib/Support/Timer.cpp @@ -210,22 +210,8 @@ public: } -static ManagedStatic NamedTimers; static ManagedStatic NamedGroupedTimers; -static Timer &getNamedRegionTimer(StringRef Name) { - sys::SmartScopedLock L(*TimerLock); - - Timer &T = (*NamedTimers)[Name]; - if (!T.isInitialized()) - T.init(Name); - return T; -} - -NamedRegionTimer::NamedRegionTimer(StringRef Name, - bool Enabled) - : TimeRegion(!Enabled ? nullptr : &getNamedRegionTimer(Name)) {} - NamedRegionTimer::NamedRegionTimer(StringRef Name, StringRef GroupName, bool Enabled) : TimeRegion(!Enabled ? nullptr : &NamedGroupedTimers->get(Name, GroupName)){} diff --git a/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp b/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp index c4adf51..54df36a 100644 --- a/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp +++ b/llvm/lib/Target/Hexagon/HexagonGenInsert.cpp @@ -1474,8 +1474,6 @@ bool HexagonGenInsert::runOnMachineFunction(MachineFunction &MF) { bool Timing = OptTiming, TimingDetail = Timing && OptTimingDetail; bool Changed = false; - TimerGroup __G("hexinsert"); - NamedRegionTimer __T("hexinsert", Timing && !TimingDetail); // Sanity check: one, but not both. assert(!OptSelectAll0 || !OptSelectHas0); -- 2.7.4