From d66e9361f5645f47b251343af1b1ed1faceb373c Mon Sep 17 00:00:00 2001 From: Steve MacLean Date: Wed, 9 Jun 2021 20:27:31 -0400 Subject: [PATCH] Apple Silicon reenable 49568 (#52202) --- src/libraries/Microsoft.CSharp/tests/DefaultParameterTests.cs | 1 - .../tests/Microsoft.Extensions.Options.Tests/OptionsBuilderTest.cs | 1 - .../tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs | 1 - .../tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs | 1 - .../tests/Microsoft.Extensions.Options.Tests/OptionsSnapshotTest.cs | 1 - .../tests/Microsoft.Extensions.Options.Tests/OptionsTest.cs | 1 - .../tests/CompositeChangeTokenTest.cs | 1 - src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs | 1 - .../tests/ImmutableDictionaryTestBase.nonnetstandard.cs | 1 - .../tests/ImmutableSortedDictionaryTest.cs | 1 - .../System/ComponentModel/Composition/CompositionContainerTests.cs | 1 - .../tests/System/Composition/Hosting/Core/CompositionHostTests.cs | 1 - src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs | 1 - src/libraries/System.Console/tests/ReadKey.cs | 1 - src/libraries/System.Console/tests/RedirectedStream.cs | 1 - .../System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs | 2 -- .../System.Diagnostics.Process/tests/ProcessCollectionTests.cs | 1 - src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs | 1 - .../System.Diagnostics.Process/tests/ProcessStartInfoTests.cs | 1 - .../System.Diagnostics.Process/tests/ProcessStreamReadTests.cs | 1 - src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs | 1 - src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs | 1 - .../System.Diagnostics.Process/tests/ProcessWaitingTests.cs | 1 - .../Conformance.dynamic.dynamicType.conversions.cs | 1 - .../Conformance.dynamic.namedandoptional.usage.executeOrder.cs | 1 - .../Conformance.dynamic.overloadResolution.Methods.1class2methods.cs | 2 -- .../tests/MemoryMappedFile.CrossProcess.cs | 1 - .../tests/AnonymousPipeTests/AnonymousPipeTest.CrossProcess.cs | 1 - .../tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs | 1 - .../System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs | 1 - .../System.Net.Http/tests/UnitTests/HttpEnvironmentProxyTest.cs | 1 - .../System.Runtime.Extensions/tests/System/AppDomainTests.cs | 2 -- .../System.Runtime.Extensions/tests/System/Environment.Exit.cs | 2 -- .../tests/System/Environment.GetCommandLineArgs.cs | 1 - .../System.Runtime.Extensions/tests/System/EnvironmentTests.cs | 5 ----- .../tests/System/Runtime/ProfileOptimization.cs | 1 - .../tests/System/UnloadingAndProcessExitTests.cs | 1 - .../tests/BinaryFormatterEventSourceTests.cs | 1 - .../tests/BinaryFormatterTests.cs | 1 - .../tests/FormatterServicesTests.cs | 1 - .../System.Runtime.Serialization.Formatters/tests/FormatterTests.cs | 1 - .../tests/SerializationInfoTests.cs | 1 - .../System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs | 1 - src/libraries/System.Text.Encodings.Web/tests/EncoderCommonTests.cs | 1 - src/libraries/System.Text.Encodings.Web/tests/HtmlEncoderTests.cs | 2 -- .../System.Text.Encodings.Web/tests/JavaScriptEncoderTests.cs | 1 - src/libraries/System.Text.Encodings.Web/tests/TextEncoderTests.cs | 2 -- src/libraries/System.Text.Encodings.Web/tests/UnicodeRangeTests.cs | 2 -- src/libraries/System.Text.Encodings.Web/tests/UnicodeRangesTests.cs | 1 - .../tests/Dataflow/ActionBlockTests.cs | 1 - src/libraries/System.Threading.Thread/tests/ThreadTests.cs | 1 - src/libraries/System.Threading/tests/MutexTests.cs | 1 - 52 files changed, 63 deletions(-) diff --git a/src/libraries/Microsoft.CSharp/tests/DefaultParameterTests.cs b/src/libraries/Microsoft.CSharp/tests/DefaultParameterTests.cs index beae75b..e6b7d35 100644 --- a/src/libraries/Microsoft.CSharp/tests/DefaultParameterTests.cs +++ b/src/libraries/Microsoft.CSharp/tests/DefaultParameterTests.cs @@ -9,7 +9,6 @@ using Xunit; namespace Microsoft.CSharp.RuntimeBinder.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class DefaultParameterTests { diff --git a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsBuilderTest.cs b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsBuilderTest.cs index 819d80d..7e00f53 100644 --- a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsBuilderTest.cs +++ b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsBuilderTest.cs @@ -12,7 +12,6 @@ using Xunit; namespace Microsoft.Extensions.Options.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class OptionsBuilderTest { [Fact] diff --git a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs index 0c8748d..fb06ea0 100644 --- a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs +++ b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs @@ -7,7 +7,6 @@ using Xunit; namespace Microsoft.Extensions.Options.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class OptionsFactoryTest { [Fact] diff --git a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs index f253d1e..858b90d 100644 --- a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs +++ b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs @@ -11,7 +11,6 @@ using Xunit; namespace Microsoft.Extensions.Options.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class OptionsMonitorTest { [Fact] diff --git a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsSnapshotTest.cs b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsSnapshotTest.cs index 0dfa2c2..adb63a5 100644 --- a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsSnapshotTest.cs +++ b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsSnapshotTest.cs @@ -10,7 +10,6 @@ using Xunit; namespace Microsoft.Extensions.Options.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class OptionsSnapshotTest { [Fact] diff --git a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsTest.cs b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsTest.cs index 7f5ed8f..bb76bb9 100644 --- a/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsTest.cs +++ b/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsTest.cs @@ -12,7 +12,6 @@ using Xunit; namespace Microsoft.Extensions.Options.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class OptionsTest { [Fact] diff --git a/src/libraries/Microsoft.Extensions.Primitives/tests/CompositeChangeTokenTest.cs b/src/libraries/Microsoft.Extensions.Primitives/tests/CompositeChangeTokenTest.cs index 549cfcc..07bb99b 100644 --- a/src/libraries/Microsoft.Extensions.Primitives/tests/CompositeChangeTokenTest.cs +++ b/src/libraries/Microsoft.Extensions.Primitives/tests/CompositeChangeTokenTest.cs @@ -103,7 +103,6 @@ namespace Microsoft.Extensions.Primitives } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public async Task RegisteredCallbackGetsInvokedExactlyOnce_WhenMultipleConcurrentChangeEventsOccur() { // Arrange diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs index 1ce0984..d9f981b 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs @@ -43,7 +43,6 @@ namespace Microsoft.VisualBasic.Tests // public static void ChDrive(string Drive){ throw null; } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void CloseAllFiles() { var fileName1 = GetTestFilePath(); diff --git a/src/libraries/System.Collections.Immutable/tests/ImmutableDictionaryTestBase.nonnetstandard.cs b/src/libraries/System.Collections.Immutable/tests/ImmutableDictionaryTestBase.nonnetstandard.cs index 36615bb..3ea83ed 100644 --- a/src/libraries/System.Collections.Immutable/tests/ImmutableDictionaryTestBase.nonnetstandard.cs +++ b/src/libraries/System.Collections.Immutable/tests/ImmutableDictionaryTestBase.nonnetstandard.cs @@ -75,7 +75,6 @@ namespace System.Collections.Immutable.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void AddRangeTest() { var map = Empty(); diff --git a/src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryTest.cs b/src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryTest.cs index eba271b..c0ba891 100644 --- a/src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryTest.cs +++ b/src/libraries/System.Collections.Immutable/tests/ImmutableSortedDictionaryTest.cs @@ -102,7 +102,6 @@ namespace System.Collections.Immutable.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ToUnorderedTest() { var sortedMap = Empty().AddRange(Enumerable.Range(1, 100).Select(n => new KeyValuePair(n, new GenericParameterHelper(n)))); diff --git a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs index 9fa7534..93432aa 100644 --- a/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs +++ b/src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerTests.cs @@ -1699,7 +1699,6 @@ namespace System.ComponentModel.Composition } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void GetExports2_TypeAsMetadataViewTypeArgument_IsUsedAsMetadataConstraint() { var metadata = new Dictionary(); diff --git a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs index 3024c07..f703345 100644 --- a/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs +++ b/src/libraries/System.Composition.Hosting/tests/System/Composition/Hosting/Core/CompositionHostTests.cs @@ -133,7 +133,6 @@ namespace System.Composition.Hosting.Core.Tests [InlineData(typeof(Lazy>))] [InlineData(typeof(Lazy))] [InlineData(typeof(Lazy))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void GetExport_InvalidMetadata_ThrowsComposititionFailedException(Type type) { using (CompositionHost host = CompositionHost.CreateCompositionHost(new ExportDescriptorProvider[0])) diff --git a/src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs b/src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs index c9d2b09..35067d2 100644 --- a/src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs +++ b/src/libraries/System.Console/tests/NonStandardConfiguration.Unix.cs @@ -12,7 +12,6 @@ namespace System.Tests { [PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invokes [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void NonBlockingStdout_AllDataReceived() { RemoteInvokeHandle remote = RemoteExecutor.Invoke(() => diff --git a/src/libraries/System.Console/tests/ReadKey.cs b/src/libraries/System.Console/tests/ReadKey.cs index e042998..42481f3 100644 --- a/src/libraries/System.Console/tests/ReadKey.cs +++ b/src/libraries/System.Console/tests/ReadKey.cs @@ -23,7 +23,6 @@ public class ReadKey } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void RedirectedConsole_ReadKey() { RunRemote(() => { Assert.Throws(() => Console.ReadKey()); return 42; }, new ProcessStartInfo() { RedirectStandardInput = true }); diff --git a/src/libraries/System.Console/tests/RedirectedStream.cs b/src/libraries/System.Console/tests/RedirectedStream.cs index ee2afb9..578824c 100644 --- a/src/libraries/System.Console/tests/RedirectedStream.cs +++ b/src/libraries/System.Console/tests/RedirectedStream.cs @@ -11,7 +11,6 @@ using Microsoft.DotNet.RemoteExecutor; using Microsoft.DotNet.XUnitExtensions; using Xunit; -[ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class RedirectedStream { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] // the CI system redirects stdout, so we can only really test the redirected behavior. diff --git a/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs b/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs index ed7e2f8..39171df 100644 --- a/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs +++ b/src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs @@ -1547,7 +1547,6 @@ namespace System.Diagnostics.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void TestTagObjects() { Activity activity = new Activity("TagObjects"); @@ -1608,7 +1607,6 @@ namespace System.Diagnostics.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void TestGetTagItem() { Activity a = new Activity("GetTagItem"); diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessCollectionTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessCollectionTests.cs index 90acc19..3ac2016 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessCollectionTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessCollectionTests.cs @@ -8,7 +8,6 @@ using Xunit; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class ProcessCollectionTests : ProcessTestBase { [Fact] diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs index e127633..2631cb8 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.cs @@ -72,7 +72,6 @@ namespace System.Diagnostics.Tests } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ModulesAreDisposedWhenProcessIsDisposed() { Process process = CreateDefaultProcess(); diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs index 1ffe9f0..b061bf4 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs @@ -22,7 +22,6 @@ using System.Security.AccessControl; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class ProcessStartInfoTests : ProcessTestBase { private const string ItemSeparator = "CAFF9451396B4EEF8A5155A15BDC2080"; // random string that shouldn't be in any env vars; used instead of newline to separate env var strings diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs index 2620f96..3cbab6c 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs @@ -14,7 +14,6 @@ using Xunit; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class ProcessStreamReadTests : ProcessTestBase { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs index 47c538a..9921aac 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs @@ -21,7 +21,6 @@ using Xunit.Sdk; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public partial class ProcessTests : ProcessTestBase { private class FinalizingProcess : Process diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs index 46305d9..2266582 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessThreadTests.cs @@ -10,7 +10,6 @@ using System.Threading.Tasks; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public partial class ProcessThreadTests : ProcessTestBase { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs index 8bd7985..5cbd89d 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs @@ -11,7 +11,6 @@ using Xunit; namespace System.Diagnostics.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class ProcessWaitingTests : ProcessTestBase { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.conversions.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.conversions.cs index a345456..d27e05b 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.conversions.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.conversions.cs @@ -397,7 +397,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.dynamicType.conversions #endregion [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.NamedAndOptional/Conformance.dynamic.namedandoptional.usage.executeOrder.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.NamedAndOptional/Conformance.dynamic.namedandoptional.usage.executeOrder.cs index a9b0ebb..b0a5792 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.NamedAndOptional/Conformance.dynamic.namedandoptional.usage.executeOrder.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.NamedAndOptional/Conformance.dynamic.namedandoptional.usage.executeOrder.cs @@ -1035,7 +1035,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.namedandoptional.usage. } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs index af1b08a..5cf0a1f 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.OverloadResolution/Conformance.dynamic.overloadResolution.Methods.1class2methods.cs @@ -2966,7 +2966,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolution.Meth } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); @@ -2998,7 +2997,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.overloadResolution.Meth } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void DynamicCSharpRunTest() { Assert.Equal(0, MainMethod()); diff --git a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CrossProcess.cs b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CrossProcess.cs index 61e5b9e..fa8f454 100644 --- a/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CrossProcess.cs +++ b/src/libraries/System.IO.MemoryMappedFiles/tests/MemoryMappedFile.CrossProcess.cs @@ -9,7 +9,6 @@ namespace System.IO.MemoryMappedFiles.Tests public class CrossProcessTests : FileCleanupTestBase { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void DataShared() { // Create a new file and load it into an MMF diff --git a/src/libraries/System.IO.Pipes/tests/AnonymousPipeTests/AnonymousPipeTest.CrossProcess.cs b/src/libraries/System.IO.Pipes/tests/AnonymousPipeTests/AnonymousPipeTest.CrossProcess.cs index ff47536..9a68529 100644 --- a/src/libraries/System.IO.Pipes/tests/AnonymousPipeTests/AnonymousPipeTest.CrossProcess.cs +++ b/src/libraries/System.IO.Pipes/tests/AnonymousPipeTests/AnonymousPipeTest.CrossProcess.cs @@ -8,7 +8,6 @@ using Xunit; namespace System.IO.Pipes.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class AnonymousPipeTest_CrossProcess { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] diff --git a/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs b/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs index 6e4fbc0..83e5234 100644 --- a/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs +++ b/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs @@ -11,7 +11,6 @@ using Xunit; namespace System.IO.Pipes.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public sealed class NamedPipeTest_CrossProcess { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] diff --git a/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs b/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs index 4eb8895..220be9d 100644 --- a/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs +++ b/src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs @@ -346,7 +346,6 @@ namespace System.IO.Pipes.Tests [Fact] [PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invoke to verify the user name - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public async Task Unix_GetImpersonationUserName_Succeed() { string pipeName = PipeStreamConformanceTests.GetUniquePipeName(); diff --git a/src/libraries/System.Net.Http/tests/UnitTests/HttpEnvironmentProxyTest.cs b/src/libraries/System.Net.Http/tests/UnitTests/HttpEnvironmentProxyTest.cs index d6c3d12..8c0669f 100644 --- a/src/libraries/System.Net.Http/tests/UnitTests/HttpEnvironmentProxyTest.cs +++ b/src/libraries/System.Net.Http/tests/UnitTests/HttpEnvironmentProxyTest.cs @@ -10,7 +10,6 @@ using Xunit.Abstractions; namespace System.Net.Http.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class HttpEnvironmentProxyTest { private readonly ITestOutputHelper _output; diff --git a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs index b3b056d..7360975 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs @@ -45,7 +45,6 @@ namespace System.Tests [Fact] [SkipOnPlatform(TestPlatforms.Browser, "throws pNSE")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] [ActiveIssue("https://github.com/dotnet/runtime/issues/49868", TestPlatforms.Android)] [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)] public void TargetFrameworkTest() @@ -212,7 +211,6 @@ namespace System.Tests } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ProcessExit_Called() { string path = GetTestFilePath(); diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs index 626aa3a..f6ef6ce 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs @@ -22,7 +22,6 @@ namespace System.Tests [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] [MemberData(nameof(ExitCodeValues))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void CheckExitCode(int expectedExitCode) { RemoteExecutor.Invoke(s => int.Parse(s), expectedExitCode.ToString(), new RemoteInvokeOptions { ExpectedExitCode = expectedExitCode }).Dispose(); @@ -43,7 +42,6 @@ namespace System.Tests [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler. [InlineData(3)] // using Exit(exitCode) [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Browser, iOS, MacCatalyst, or tvOS.")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] [ActiveIssue("https://github.com/dotnet/runtime/issues/49868", TestPlatforms.Android)] public static void ExitCode_VoidMainAppReturnsSetValue(int mode) { diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetCommandLineArgs.cs b/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetCommandLineArgs.cs index ae0d4a6..695af6b 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetCommandLineArgs.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Environment.GetCommandLineArgs.cs @@ -23,7 +23,6 @@ namespace System.Tests [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] [MemberData(nameof(GetCommandLineArgs_TestData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void GetCommandLineArgs_Invoke_ReturnsExpected(string[] args) { switch (args.Length) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index b192b09..ed12573 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -83,7 +83,6 @@ namespace System.Tests } [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ProcessId_MatchesExpectedValue() { using RemoteInvokeHandle handle = RemoteExecutor.Invoke(() => Console.WriteLine(Environment.ProcessId), new RemoteInvokeOptions { StartInfo = new ProcessStartInfo { RedirectStandardOutput = true } }); @@ -97,7 +96,6 @@ namespace System.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ProcessPath_MatchesExpectedValue() { string expectedProcessPath = PlatformDetection.IsBrowser ? null : Process.GetCurrentProcess().MainModule.FileName; @@ -268,7 +266,6 @@ namespace System.Tests [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // fail fast crashes the process [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void FailFast_ExceptionStackTrace_ArgumentException() { var psi = new ProcessStartInfo(); @@ -290,7 +287,6 @@ namespace System.Tests [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // fail fast crashes the process [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void FailFast_ExceptionStackTrace_StackOverflowException() { // Test using another type of exception @@ -313,7 +309,6 @@ namespace System.Tests [Trait(XunitConstants.Category, XunitConstants.IgnoreForCI)] // fail fast crashes the process [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void FailFast_ExceptionStackTrace_InnerException() { // Test if inner exception details are also logged diff --git a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs index 7f980ff..530661c 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/Runtime/ProfileOptimization.cs @@ -14,7 +14,6 @@ namespace System.Runtime.Tests [InlineData(false)] [InlineData(true)] [ActiveIssue("https://github.com/dotnet/runtime/issues/31853", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void ProfileOptimization_CheckFileExists(bool stopProfile) { string profileFile = GetTestFileName(); diff --git a/src/libraries/System.Runtime.Extensions/tests/System/UnloadingAndProcessExitTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/UnloadingAndProcessExitTests.cs index 7e37f41..577b526 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/UnloadingAndProcessExitTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/UnloadingAndProcessExitTests.cs @@ -12,7 +12,6 @@ namespace System.Tests public class UnloadingAndProcessExitTests : FileCleanupTestBase { [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void UnloadingEventMustHappenBeforeProcessExitEvent() { string fileName = GetTestFilePath(); diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterEventSourceTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterEventSourceTests.cs index d955b83..805b1ad 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterEventSourceTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterEventSourceTests.cs @@ -12,7 +12,6 @@ using Xunit; namespace System.Runtime.Serialization.Formatters.Tests { [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static class BinaryFormatterEventSourceTests { private const string BinaryFormatterEventSourceName = "System.Runtime.Serialization.Formatters.Binary.BinaryFormatterEventSource"; diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index b407648..7bd5ede 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -19,7 +19,6 @@ using Xunit; namespace System.Runtime.Serialization.Formatters.Tests { [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public partial class BinaryFormatterTests : FileCleanupTestBase { // On 32-bit we can't test these high inputs as they cause OutOfMemoryExceptions. diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs index 6d2bca0..0a04f25 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs @@ -9,7 +9,6 @@ using Xunit; namespace System.Runtime.Serialization.Formatters.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public partial class FormatterServicesTests { [Fact] diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterTests.cs index e1195cd..68ca34e 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/FormatterTests.cs @@ -8,7 +8,6 @@ using Xunit; namespace System.Runtime.Serialization.Formatters.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class FormatterTests { [Fact] diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationInfoTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationInfoTests.cs index e135157..30b72ce 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationInfoTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/SerializationInfoTests.cs @@ -6,7 +6,6 @@ using Xunit; namespace System.Runtime.Serialization.Formatters.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public class SerializationInfoTests { [Fact] diff --git a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs index d1ce413..a576fcf 100644 --- a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs +++ b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs @@ -21,7 +21,6 @@ using Xunit; using System.Runtime.Serialization.Tests; -[ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static partial class DataContractSerializerTests { #if ReflectionOnly diff --git a/src/libraries/System.Text.Encodings.Web/tests/EncoderCommonTests.cs b/src/libraries/System.Text.Encodings.Web/tests/EncoderCommonTests.cs index 8169576..239a629 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/EncoderCommonTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/EncoderCommonTests.cs @@ -13,7 +13,6 @@ namespace System.Text.Encodings.Web.Tests [InlineData(5000, 3, 15000)] // haven't exceeded the 16k cap [InlineData(40000, 3, 40000)] // if we spill over the LOH, we still allocate an output buffer equivalent in length to the input buffer [InlineData(512, int.MaxValue, 16 * 1024)] // make sure we can handle numeric overflow - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void GetCapacityOfOutputStringBuilder(int numCharsToEncode, int worstCaseOutputCharsPerInputChar, int expectedResult) { Assert.Equal(expectedResult, EncoderCommon.GetCapacityOfOutputStringBuilder(numCharsToEncode, worstCaseOutputCharsPerInputChar)); diff --git a/src/libraries/System.Text.Encodings.Web/tests/HtmlEncoderTests.cs b/src/libraries/System.Text.Encodings.Web/tests/HtmlEncoderTests.cs index 0621653..4321a99 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/HtmlEncoderTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/HtmlEncoderTests.cs @@ -16,7 +16,6 @@ namespace System.Text.Encodings.Web.Tests [InlineData("😂 21", "\U0001F602 21")] [InlineData("x😂y", "x\U0001F602y")] [InlineData("😂x😂y", "\U0001F602x\U0001F602y")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void TestSurrogate(string expected, string actual) { Assert.Equal(expected, HtmlEncoder.Default.Encode(actual)); @@ -96,7 +95,6 @@ namespace System.Text.Encodings.Web.Tests [InlineData("'", "'")] [InlineData("\"", """)] [InlineData("+", "+")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void HtmlEncode_AllRangesAllowed_StillEncodesForbiddenChars_Simple(string input, string expected) { // Arrange diff --git a/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.cs b/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.cs index 161ba61..c57a84e 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/JavaScriptEncoderTests.cs @@ -11,7 +11,6 @@ using Xunit; namespace System.Text.Encodings.Web.Tests { - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public partial class JavaScriptEncoderTests { [Fact] diff --git a/src/libraries/System.Text.Encodings.Web/tests/TextEncoderTests.cs b/src/libraries/System.Text.Encodings.Web/tests/TextEncoderTests.cs index 35166fb..cb26b48 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/TextEncoderTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/TextEncoderTests.cs @@ -53,7 +53,6 @@ namespace System.Text.Encodings.Web.Tests [InlineData(10, 10)] [InlineData(11, 11)] [InlineData(12, 11)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void EncodeUtf8_WellFormedInput_DoesNotRequireEncoding_CopiedToDestinationCorrectly(int destinationSize, int expectedBytesCopied) { // This test considers input which is well-formed and doesn't need to be encoded. @@ -258,7 +257,6 @@ namespace System.Text.Encodings.Web.Tests [InlineData(new byte[] { 0xF1, 0x80, 0x80 }, 0)] [InlineData(new byte[] { 0xF1, 0x80, 0x80, 0x80, 0xFF }, 4)] [InlineData(new byte[] { 0xFF, 0x80, 0x80, 0x80, 0xFF }, 0)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void FindFirstCharToEncodeUtf8_IllFormedData_ReturnsIndexOfIllFormedSubsequence(byte[] utf8Data, int expectedIndex) { // Arrange diff --git a/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangeTests.cs b/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangeTests.cs index c54b770..51d1d9a 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangeTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangeTests.cs @@ -12,7 +12,6 @@ namespace System.Text.Encodings.Web.Tests [Theory] [InlineData(-1, 16)] [InlineData(0x10000, 16)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void Ctor_FailureCase_FirstCodePoint(int firstCodePoint, int rangeSize) { AssertExtensions.Throws("firstCodePoint", () => new UnicodeRange(firstCodePoint, rangeSize)); @@ -21,7 +20,6 @@ namespace System.Text.Encodings.Web.Tests [Theory] [InlineData(0x0100, -1)] [InlineData(0x0100, 0x10000)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void Ctor_FailureCase_RangeSize(int firstCodePoint, int rangeSize) { AssertExtensions.Throws("length", () => new UnicodeRange(firstCodePoint, rangeSize)); diff --git a/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangesTests.cs b/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangesTests.cs index 4217d13..efa50bf 100644 --- a/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangesTests.cs +++ b/src/libraries/System.Text.Encodings.Web/tests/UnicodeRangesTests.cs @@ -27,7 +27,6 @@ namespace System.Text.Unicode.Tests [Theory] [MemberData(nameof(UnicodeRanges_GeneratedData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public static void Range_Unicode(ushort first, ushort last, string blockName) { Assert.Equal(0x0, first & 0xF); // first char in any block should be U+nnn0 diff --git a/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs b/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs index 3566842..55f7c4f 100644 --- a/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs +++ b/src/libraries/System.Threading.Tasks.Dataflow/tests/Dataflow/ActionBlockTests.cs @@ -366,7 +366,6 @@ namespace System.Threading.Tasks.Dataflow.Tests } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public async Task TestFaulting() { for (int trial = 0; trial < 3; trial++) diff --git a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs index acfd85e..23a9c0d 100644 --- a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs +++ b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs @@ -169,7 +169,6 @@ namespace System.Threading.Threads.Tests [InlineData("MTAMain.exe", "SetApartmentStateTest")] [InlineData("DefaultApartmentStateMain.exe", "GetApartmentStateTest")] [InlineData("DefaultApartmentStateMain.exe", "SetApartmentStateTest")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] [ActiveIssue("https://github.com/dotnet/runtime/issues/50577", TestPlatforms.Android)] [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on iOS, MacCatalyst, or tvOS.")] public static void ApartmentState_AttributePresent(string appName, string testName) diff --git a/src/libraries/System.Threading/tests/MutexTests.cs b/src/libraries/System.Threading/tests/MutexTests.cs index c7fea35..a893662 100644 --- a/src/libraries/System.Threading/tests/MutexTests.cs +++ b/src/libraries/System.Threading/tests/MutexTests.cs @@ -406,7 +406,6 @@ namespace System.Threading.Tests [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] [ActiveIssue("https://github.com/dotnet/runtime/issues/36307", TestRuntimes.Mono)] [MemberData(nameof(CrossProcess_NamedMutex_ProtectedFileAccessAtomic_MemberData))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/49568", typeof(PlatformDetection), nameof(PlatformDetection.IsMacOsAppleSilicon))] public void CrossProcess_NamedMutex_ProtectedFileAccessAtomic(string prefix) { string fileName = GetTestFilePath(); -- 2.7.4