From d637235ceed7517287c8b4a724ef58a4681b8ed3 Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Wed, 24 Feb 2021 19:16:16 +1100 Subject: [PATCH] [JITLink] Fix comments about JITLink's generic link algorithm. These comments had gotten out of date with the code. --- llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h b/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h index 1d28f50..8d55109 100644 --- a/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h +++ b/llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h @@ -56,15 +56,18 @@ protected: // 1.2: Prune graph // 1.3: Run post-prune passes // 1.4: Sort blocks into segments - // 1.5: Allocate segment memory - // 1.6: Identify externals and make an async call to resolve function + // 1.5: Allocate segment memory, update node vmaddrs to target vmaddrs + // 1.6: Run post-allocation passes + // 1.7: Notify context of final assigned symbol addresses + // 1.8: Identify external symbols and make an async call to resolve void linkPhase1(std::unique_ptr Self); // Phase 2: // 2.1: Apply resolution results - // 2.2: Fix up block contents - // 2.3: Call OnResolved callback - // 2.3: Make an async call to transfer and finalize memory. + // 2.2: Run pre-fixup passes + // 2.3: Fix up block contents + // 2.4: Run post-fixup passes + // 2.5: Make an async call to transfer and finalize memory. void linkPhase2(std::unique_ptr Self, Expected LookupResult, SegmentLayoutMap Layout); -- 2.7.4