From d601e3726d2cec94429c6a2ef1f5fc940264e99b Mon Sep 17 00:00:00 2001 From: redi Date: Tue, 29 Oct 2013 21:19:34 +0000 Subject: [PATCH] * include/bits/hashtable.cc (__access_protected_ctor): Define and use new type instead of _Hashtable_ebo_helper. * testsuite/23_containers/unordered_set/ not_default_constructible_hash_neg.cc: Adjust line number. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@204182 138bc75d-0d04-0410-961f-82ee72b054a4 --- libstdc++-v3/ChangeLog | 7 +++++++ libstdc++-v3/include/bits/hashtable.h | 9 +++++---- .../unordered_set/not_default_constructible_hash_neg.cc | 2 +- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 1b83aa5..117f6d7 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,10 @@ +2013-10-29 Jonathan Wakely + + * include/bits/hashtable.cc (__access_protected_ctor): Define and use + new type instead of _Hashtable_ebo_helper. + * testsuite/23_containers/unordered_set/ + not_default_constructible_hash_neg.cc: Adjust line number. + 2013-10-28 Tim Shen * regex_executor.tcc: Add comments. diff --git a/libstdc++-v3/include/bits/hashtable.h b/libstdc++-v3/include/bits/hashtable.h index c639c55..aae146b 100644 --- a/libstdc++-v3/include/bits/hashtable.h +++ b/libstdc++-v3/include/bits/hashtable.h @@ -277,14 +277,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION "Functor used to map hash code to bucket index" " must be default constructible"); + // _Hash_code_base has a protected default constructor, so use this + // derived type to tell if it's usable. + struct __access_protected_ctor : __hash_code_base { }; + // When hash codes are not cached local iterator inherits from // __hash_code_base above to compute node bucket index so it has to be // default constructible. static_assert(__if_hash_not_cached< - is_default_constructible< - // We use _Hashtable_ebo_helper to access the protected - // default constructor. - __detail::_Hashtable_ebo_helper<0, __hash_code_base, true>>>::value, + is_default_constructible<__access_protected_ctor>>::value, "Cache the hash code or make functors involved in hash code" " and bucket index computation default constructible"); diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc index 3332cc5..4216b91 100644 --- a/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/not_default_constructible_hash_neg.cc @@ -19,7 +19,7 @@ // with this library; see the file COPYING3. If not see // . -// { dg-error "default constructible" "" { target *-*-* } 283 } +// { dg-error "default constructible" "" { target *-*-* } 287 } #include -- 2.7.4