From d5d962265d99088ce96480db3e61358d7170e24c Mon Sep 17 00:00:00 2001 From: Rob Jones Date: Wed, 17 Sep 2014 09:56:40 +0100 Subject: [PATCH] fs/fscache/object-list.c: use __seq_open_private() Reduce boilerplate code by using __seq_open_private() instead of seq_open() in fscache_objlist_open(). Signed-off-by: Rob Jones Signed-off-by: David Howells Acked-by: Steve Dickson --- fs/fscache/object-list.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c index b8179ca..51dde81 100644 --- a/fs/fscache/object-list.c +++ b/fs/fscache/object-list.c @@ -380,26 +380,14 @@ no_config: static int fscache_objlist_open(struct inode *inode, struct file *file) { struct fscache_objlist_data *data; - struct seq_file *m; - int ret; - ret = seq_open(file, &fscache_objlist_ops); - if (ret < 0) - return ret; - - m = file->private_data; - - /* buffer for key extraction */ - data = kmalloc(sizeof(struct fscache_objlist_data), GFP_KERNEL); - if (!data) { - seq_release(inode, file); + data = __seq_open_private(file, &fscache_objlist_ops, sizeof(*data)); + if (!data) return -ENOMEM; - } /* get the configuration key */ fscache_objlist_config(data); - m->private = data; return 0; } -- 2.7.4