From d46631c5c7312ad613397f8238c7a9714ae3ae94 Mon Sep 17 00:00:00 2001 From: Vineeth T M Date: Thu, 28 Aug 2014 16:13:29 +0530 Subject: [PATCH] imagefreeze: Remove impossible error condition We return EOS after the first buffer, and GstPad will make sure now that we won't get any other buffer afterwards until a flush happens. No need to check for it ourselves. https://bugzilla.gnome.org/show_bug.cgi?id=735581 --- gst/imagefreeze/gstimagefreeze.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gst/imagefreeze/gstimagefreeze.c b/gst/imagefreeze/gstimagefreeze.c index 9b13c14..9395db9 100644 --- a/gst/imagefreeze/gstimagefreeze.c +++ b/gst/imagefreeze/gstimagefreeze.c @@ -669,14 +669,9 @@ gst_image_freeze_sink_chain (GstPad * pad, GstObject * parent, { GstImageFreeze *self = GST_IMAGE_FREEZE (parent); - g_mutex_lock (&self->lock); - if (self->buffer) { - GST_DEBUG_OBJECT (pad, "Already have a buffer, dropping"); - gst_buffer_unref (buffer); - g_mutex_unlock (&self->lock); - return GST_FLOW_EOS; - } + g_return_val_if_fail (self->buffer == NULL, GST_FLOW_ERROR); + g_mutex_lock (&self->lock); self->buffer = buffer; gst_pad_start_task (self->srcpad, (GstTaskFunction) gst_image_freeze_src_loop, -- 2.7.4