From d3924d4245183a652c3ca8349e0769810a43747c Mon Sep 17 00:00:00 2001 From: SangHyeon Lee Date: Fri, 10 Apr 2015 14:30:46 +0900 Subject: [PATCH] list/genlist/gengrid: Fix default return value in eolian APIs. Summary: Some APIs need to return specific values for their usage. For Examples, elm_xx_select_mode_get function need to return ELM_OBJECT_SELECT_MODE_MAX when invalid input comes. **Fixed API list :** elm_list_mode_get elm_list_multi_select_mode_get elm_genlist_mode_get elm_genlist_select_mode_get elm_genlist_multi_select_mode_get elm_genlist_item_type_get elm_genlist_ttem_index_get elm_genlist_item_select_mode_get elm_gengrid_select_mode_get elm_gengrid_multi_select_mode_get elm_gengrid_item_index_get Test Plan: Call API with NULL parameter and check return value. Reviewers: Hermet, seoz, jaehwan, raster, eunue Subscribers: id213sin Differential Revision: https://phab.enlightenment.org/D2306 Change-Id: Id8c83fcb408a95f5b4f89a93371c61903777fa8e Origin: upstream --- src/lib/elm_gengrid.eo | 4 ++-- src/lib/elm_gengrid_item.eo | 2 +- src/lib/elm_genlist.eo | 6 +++--- src/lib/elm_genlist_item.eo | 6 +++--- src/lib/elm_list.eo | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/lib/elm_gengrid.eo b/src/lib/elm_gengrid.eo index 74d7199..506f0c3 100644 --- a/src/lib/elm_gengrid.eo +++ b/src/lib/elm_gengrid.eo @@ -178,7 +178,7 @@ class Elm_Gengrid (Elm_Layout, Elm_Interface_Scrollable, Evas.Clickable_Interfac @ingroup Gengrid */ } values { - Elm_Object_Select_Mode mode; /*@ The select mode */ + Elm_Object_Select_Mode mode(4); /*@ The select mode */ } } reorder_mode { @@ -291,7 +291,7 @@ class Elm_Gengrid (Elm_Layout, Elm_Interface_Scrollable, Evas.Clickable_Interfac @since 1.8 */ } values { - Elm_Object_Multi_Select_Mode mode; /*@ The multi select mode */ + Elm_Object_Multi_Select_Mode mode(2); /*@ The multi select mode */ } } horizontal { diff --git a/src/lib/elm_gengrid_item.eo b/src/lib/elm_gengrid_item.eo index 8548696..a7966ac 100644 --- a/src/lib/elm_gengrid_item.eo +++ b/src/lib/elm_gengrid_item.eo @@ -93,7 +93,7 @@ class Elm_Gengrid_Item(Elm_Widget_Item) */ } values { - int index; /*@ @return the position inside the list of item. */ + int index(-1); /*@ @return the position inside the list of item. */ } } pos { diff --git a/src/lib/elm_genlist.eo b/src/lib/elm_genlist.eo index dcf40f3..026a93d 100644 --- a/src/lib/elm_genlist.eo +++ b/src/lib/elm_genlist.eo @@ -71,7 +71,7 @@ class Elm_Genlist (Elm_Layout, Elm_Interface_Scrollable, Evas.Clickable_Interfac @ingroup Genlist */ } values { - Elm_Object_Select_Mode mode; /*@ The select mode */ + Elm_Object_Select_Mode mode(4); /*@ The select mode */ } } focus_on_selection { @@ -239,7 +239,7 @@ class Elm_Genlist (Elm_Layout, Elm_Interface_Scrollable, Evas.Clickable_Interfac @since 1.8 */ } values { - Elm_Object_Multi_Select_Mode mode; /*@ The multi select mode */ + Elm_Object_Multi_Select_Mode mode(2); /*@ The multi select mode */ } } block_count { @@ -370,7 +370,7 @@ class Elm_Genlist (Elm_Layout, Elm_Interface_Scrollable, Evas.Clickable_Interfac @ingroup Genlist */ } values { - Elm_List_Mode mode; /*@ The mode to use (one of #ELM_LIST_SCROLL or #ELM_LIST_LIMIT). */ + Elm_List_Mode mode(4); /*@ The mode to use (one of #ELM_LIST_SCROLL or #ELM_LIST_LIMIT). */ } } decorated_item { diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo index 9c6eecb..34a6179 100644 --- a/src/lib/elm_genlist_item.eo +++ b/src/lib/elm_genlist_item.eo @@ -175,7 +175,7 @@ class Elm_Genlist_Item(Elm_Widget_Item) */ } values { - int index; /*@ @return the position inside the list of item. */ + int index(-1); /*@ @return the position inside the list of item. */ } } decorate_mode { @@ -267,7 +267,7 @@ class Elm_Genlist_Item(Elm_Widget_Item) */ } values { - Elm_Object_Select_Mode mode; /*@ The selected mode */ + Elm_Object_Select_Mode mode(4); /*@ The selected mode */ } } type { @@ -284,7 +284,7 @@ class Elm_Genlist_Item(Elm_Widget_Item) */ } values { - Elm_Genlist_Item_Type type; /*@ Item tupe */ + Elm_Genlist_Item_Type type(4); /*@ Item tupe */ } } } diff --git a/src/lib/elm_list.eo b/src/lib/elm_list.eo index 5c08e7d..f1b9556 100644 --- a/src/lib/elm_list.eo +++ b/src/lib/elm_list.eo @@ -159,7 +159,7 @@ class Elm_List (Elm_Layout, Elm_Interface_Scrollable, @since 1.8 */ } values { - Elm_Object_Multi_Select_Mode mode; /*@ The multi select mode */ + Elm_Object_Multi_Select_Mode mode(2); /*@ The multi select mode */ } } mode { @@ -195,7 +195,7 @@ class Elm_List (Elm_Layout, Elm_Interface_Scrollable, @ingroup List */ } values { - Elm_List_Mode mode; /*@ One of #Elm_List_Mode: #ELM_LIST_COMPRESS, + Elm_List_Mode mode(4); /*@ One of #Elm_List_Mode: #ELM_LIST_COMPRESS, #ELM_LIST_SCROLL, #ELM_LIST_LIMIT or #ELM_LIST_EXPAND. */ } } -- 2.7.4