From d2d6720a93a2469fb3a752bd59674bd2cf97d91f Mon Sep 17 00:00:00 2001 From: Liqiang Tao Date: Wed, 31 Mar 2021 19:52:58 +0800 Subject: [PATCH] [InlineCost] Remove TODO comment that consider other forms of savings in the cost-benefit analysis Attempts to compute savings more accurately cannot impact the set of critically important call sites. Reviewed By: kazu Differential Revision: https://reviews.llvm.org/D98577 --- llvm/lib/Analysis/InlineCost.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp index 06e4d9b..06cc778 100644 --- a/llvm/lib/Analysis/InlineCost.cpp +++ b/llvm/lib/Analysis/InlineCost.cpp @@ -761,9 +761,6 @@ class InlineCostCallAnalyzer final : public CallAnalyzer { CurrentSavings += InlineConstants::InstrCost; } } - // TODO: Consider other forms of savings like switch statements, - // indirect calls becoming direct, SROACostSavings, LoadEliminationCost, - // etc. } auto ProfileCount = CalleeBFI->getBlockProfileCount(&BB); -- 2.7.4