From d29c8c214cb296e0e20f6e88f27535c340ca98db Mon Sep 17 00:00:00 2001 From: Alan Hayward Date: Fri, 10 Aug 2018 10:17:12 +0100 Subject: [PATCH] Rename size in get_core_register_section Make it clearer that the size field indicates the size of the section. gdb/ * corelow.c (core_target::get_core_register_section): Rename min_size to section_min_size. --- gdb/ChangeLog | 5 +++++ gdb/corelow.c | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a6c1cd2..47ef755 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-08-28 Alan Hayward + + * corelow.c (core_target::get_core_register_section): Rename + min_size to section_min_size. + 2018-08-25 Simon Marchi * python/py-threadevent.c (py_get_event_thread): Initialize diff --git a/gdb/corelow.c b/gdb/corelow.c index ecf9665..febeac4 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -106,7 +106,7 @@ public: void get_core_register_section (struct regcache *regcache, const struct regset *regset, const char *name, - int min_size, + int section_min_size, int which, const char *human_name, bool required); @@ -570,7 +570,7 @@ void core_target::get_core_register_section (struct regcache *regcache, const struct regset *regset, const char *name, - int min_size, + int section_min_size, int which, const char *human_name, bool required) @@ -593,13 +593,13 @@ core_target::get_core_register_section (struct regcache *regcache, } size = bfd_section_size (core_bfd, section); - if (size < min_size) + if (size < section_min_size) { warning (_("Section `%s' in core file too small."), section_name.c_str ()); return; } - if (size != min_size && !variable_size_section) + if (size != section_min_size && !variable_size_section) { warning (_("Unexpected size of section `%s' in core file."), section_name.c_str ()); -- 2.7.4