From d2791a7844b83bb0bad40784541aa57403214f6e Mon Sep 17 00:00:00 2001 From: Gwenole Beauchesne Date: Tue, 2 Jun 2015 11:46:00 +0200 Subject: [PATCH] decoder: h264: fix uninitialized variables in avcC mode. Fix uninitialized variables when decoding SPS and PPS NAL units from "codec-data" buffers. This is particularly important when seeking ops are involved, and the new persistent states are used more often. https://bugzilla.gnome.org/show_bug.cgi?id=750094 --- gst-libs/gst/vaapi/gstvaapidecoder_h264.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gst-libs/gst/vaapi/gstvaapidecoder_h264.c b/gst-libs/gst/vaapi/gstvaapidecoder_h264.c index 20d96ceec0..677e73b7ac 100644 --- a/gst-libs/gst/vaapi/gstvaapidecoder_h264.c +++ b/gst-libs/gst/vaapi/gstvaapidecoder_h264.c @@ -4285,6 +4285,9 @@ gst_vaapi_decoder_h264_decode_codec_data(GstVaapiDecoder *base_decoder, goto cleanup; ofs = pi->nalu.offset + pi->nalu.size; + pi->state = priv->parser_state; + pi->flags = 0; + status = decode_sps(decoder, &unit); if (status != GST_VAAPI_DECODER_STATUS_SUCCESS) goto cleanup; @@ -4315,6 +4318,9 @@ gst_vaapi_decoder_h264_decode_codec_data(GstVaapiDecoder *base_decoder, goto cleanup; ofs = pi->nalu.offset + pi->nalu.size; + pi->state = priv->parser_state; + pi->flags = 0; + status = decode_pps(decoder, &unit); if (status != GST_VAAPI_DECODER_STATUS_SUCCESS) goto cleanup; -- 2.34.1