From d244f3dbd6cfd241dc1db611c0325daedfcab9c6 Mon Sep 17 00:00:00 2001 From: Dong Du Date: Thu, 29 Jul 2021 00:15:35 +0800 Subject: [PATCH] lib: sbi: Fix bug in strncmp function when count is 0 No need to compare characters when the count turns to 0. Fix the issue in sbi_strncmp. Signed-off-by: Dong Du Reviewed-by: Bin Meng Reviewed-by: Anup Patel --- lib/sbi/sbi_string.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/sbi/sbi_string.c b/lib/sbi/sbi_string.c index 7805ba4..c87bce9 100644 --- a/lib/sbi/sbi_string.c +++ b/lib/sbi/sbi_string.c @@ -33,6 +33,10 @@ int sbi_strncmp(const char *a, const char *b, size_t count) for (; count > 0 && *a == *b && *a != '\0'; a++, b++, count--) ; + /* No difference till the end */ + if (!count) + return 0; + return *a - *b; } -- 2.7.4