From d2168c2de6ed7bab577b889ab413b03a2ca4a274 Mon Sep 17 00:00:00 2001 From: mstarzinger Date: Tue, 18 Aug 2015 10:55:19 -0700 Subject: [PATCH] Remove grab-bag includes of v8.h from runtime entries. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1293053004 Cr-Commit-Position: refs/heads/master@{#30232} --- src/json-parser.h | 4 ++++ src/json-stringifier.h | 1 + src/runtime/runtime-array.cc | 6 ++++-- src/runtime/runtime-atomics.cc | 6 +++--- src/runtime/runtime-classes.cc | 6 ++---- src/runtime/runtime-collections.cc | 6 +++--- src/runtime/runtime-compiler.cc | 3 +-- src/runtime/runtime-date.cc | 5 +++-- src/runtime/runtime-debug.cc | 3 +-- src/runtime/runtime-forin.cc | 5 +++-- src/runtime/runtime-function.cc | 3 +-- src/runtime/runtime-futex.cc | 7 +++---- src/runtime/runtime-generator.cc | 5 +++-- src/runtime/runtime-i18n.cc | 5 +++-- src/runtime/runtime-internal.cc | 3 +-- src/runtime/runtime-json.cc | 4 ++-- src/runtime/runtime-literals.cc | 3 +-- src/runtime/runtime-liveedit.cc | 3 +-- src/runtime/runtime-maths.cc | 4 +--- src/runtime/runtime-numbers.cc | 3 +-- src/runtime/runtime-object.cc | 3 +-- src/runtime/runtime-observe.cc | 3 +-- src/runtime/runtime-proxy.cc | 5 +++-- src/runtime/runtime-regexp.cc | 3 ++- src/runtime/runtime-scopes.cc | 3 +-- src/runtime/runtime-simd.cc | 5 +++-- src/runtime/runtime-strings.cc | 4 ++-- src/runtime/runtime-symbol.cc | 4 ++-- src/runtime/runtime-test.cc | 3 +-- src/runtime/runtime-typedarray.cc | 6 +++--- src/runtime/runtime-uri.cc | 5 ++--- src/runtime/runtime.cc | 6 ++++-- 32 files changed, 67 insertions(+), 68 deletions(-) diff --git a/src/json-parser.h b/src/json-parser.h index 99e48f1..81c83bd 100644 --- a/src/json-parser.h +++ b/src/json-parser.h @@ -7,8 +7,12 @@ #include "src/char-predicates.h" #include "src/conversions.h" +#include "src/factory.h" #include "src/messages.h" +#include "src/scanner.h" #include "src/token.h" +#include "src/transitions.h" +#include "src/types.h" namespace v8 { namespace internal { diff --git a/src/json-stringifier.h b/src/json-stringifier.h index 5d7235e..fb6b80d 100644 --- a/src/json-stringifier.h +++ b/src/json-stringifier.h @@ -6,6 +6,7 @@ #define V8_JSON_STRINGIFIER_H_ #include "src/conversions.h" +#include "src/lookup.h" #include "src/messages.h" #include "src/string-builder.h" #include "src/utils.h" diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc index 3e05f76..fa0d91b 100644 --- a/src/runtime/runtime-array.cc +++ b/src/runtime/runtime-array.cc @@ -2,12 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/conversions-inl.h" #include "src/elements.h" +#include "src/factory.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" +#include "src/prototype.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-atomics.cc b/src/runtime/runtime-atomics.cc index bf28e14..9b9fa0b 100644 --- a/src/runtime/runtime-atomics.cc +++ b/src/runtime/runtime-atomics.cc @@ -2,13 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/base/macros.h" #include "src/base/platform/mutex.h" -#include "src/conversions.h" -#include "src/runtime/runtime-utils.h" +#include "src/conversions-inl.h" +#include "src/factory.h" // Implement Atomic accesses to SharedArrayBuffers as defined in the // SharedArrayBuffer draft spec, found here diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc index 3db4330..8692b9b 100644 --- a/src/runtime/runtime-classes.cc +++ b/src/runtime/runtime-classes.cc @@ -2,18 +2,16 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include "src/runtime/runtime-utils.h" + #include #include -#include "src/v8.h" - #include "src/arguments.h" #include "src/debug/debug.h" #include "src/frames-inl.h" #include "src/messages.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" - namespace v8 { namespace internal { diff --git a/src/runtime/runtime-collections.cc b/src/runtime/runtime-collections.cc index b8a97c7..3450fca 100644 --- a/src/runtime/runtime-collections.cc +++ b/src/runtime/runtime-collections.cc @@ -2,11 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - -#include "src/arguments.h" #include "src/runtime/runtime-utils.h" +#include "src/arguments.h" +#include "src/conversions-inl.h" +#include "src/factory.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-compiler.cc b/src/runtime/runtime-compiler.cc index f781970..e7f567f 100644 --- a/src/runtime/runtime-compiler.cc +++ b/src/runtime/runtime-compiler.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/compiler.h" @@ -10,7 +10,6 @@ #include "src/frames-inl.h" #include "src/full-codegen/full-codegen.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" #include "src/v8threads.h" #include "src/vm-state-inl.h" diff --git a/src/runtime/runtime-date.cc b/src/runtime/runtime-date.cc index c47b158..4231d82 100644 --- a/src/runtime/runtime-date.cc +++ b/src/runtime/runtime-date.cc @@ -2,13 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/conversions-inl.h" #include "src/date.h" #include "src/dateparser-inl.h" +#include "src/factory.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc index d4acf79..1cd524f 100644 --- a/src/runtime/runtime-debug.cc +++ b/src/runtime/runtime-debug.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/debug/debug.h" @@ -11,7 +11,6 @@ #include "src/debug/debug-scopes.h" #include "src/frames-inl.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc index c793e88..ecd55d1 100644 --- a/src/runtime/runtime-forin.cc +++ b/src/runtime/runtime-forin.cc @@ -2,9 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/arguments.h" #include "src/runtime/runtime-utils.h" -#include "src/v8.h" + +#include "src/arguments.h" +#include "src/objects-inl.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-function.cc b/src/runtime/runtime-function.cc index 8eff2fd..a368f1b 100644 --- a/src/runtime/runtime-function.cc +++ b/src/runtime/runtime-function.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/accessors.h" #include "src/arguments.h" @@ -11,7 +11,6 @@ #include "src/deoptimizer.h" #include "src/frames-inl.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-futex.cc b/src/runtime/runtime-futex.cc index 590c66b..a96758d 100644 --- a/src/runtime/runtime-futex.cc +++ b/src/runtime/runtime-futex.cc @@ -2,14 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/futex-emulation.h" - -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/base/platform/time.h" +#include "src/conversions-inl.h" +#include "src/futex-emulation.h" #include "src/globals.h" -#include "src/runtime/runtime-utils.h" // Implement Futex API for SharedArrayBuffers as defined in the // SharedArrayBuffer draft spec, found here: diff --git a/src/runtime/runtime-generator.cc b/src/runtime/runtime-generator.cc index ed86c4d..208f7f6 100644 --- a/src/runtime/runtime-generator.cc +++ b/src/runtime/runtime-generator.cc @@ -2,11 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/factory.h" #include "src/frames-inl.h" -#include "src/runtime/runtime-utils.h" +#include "src/objects-inl.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-i18n.cc b/src/runtime/runtime-i18n.cc index 3da71a9..73d5110 100644 --- a/src/runtime/runtime-i18n.cc +++ b/src/runtime/runtime-i18n.cc @@ -4,13 +4,14 @@ #ifdef V8_I18N_SUPPORT -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" +#include "src/api.h" #include "src/api-natives.h" #include "src/arguments.h" +#include "src/factory.h" #include "src/i18n.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" #include "unicode/brkiter.h" #include "unicode/calendar.h" diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc index e6ea9fd..d39a12c 100644 --- a/src/runtime/runtime-internal.cc +++ b/src/runtime/runtime-internal.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/bootstrapper.h" @@ -12,7 +12,6 @@ #include "src/messages.h" #include "src/parser.h" #include "src/prettyprinter.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-json.cc b/src/runtime/runtime-json.cc index 366e6e7..64a42bf 100644 --- a/src/runtime/runtime-json.cc +++ b/src/runtime/runtime-json.cc @@ -2,13 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/char-predicates-inl.h" #include "src/json-parser.h" #include "src/json-stringifier.h" -#include "src/runtime/runtime-utils.h" +#include "src/objects-inl.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-literals.cc b/src/runtime/runtime-literals.cc index 80af962..f434747 100644 --- a/src/runtime/runtime-literals.cc +++ b/src/runtime/runtime-literals.cc @@ -2,14 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/allocation-site-scopes.h" #include "src/arguments.h" #include "src/ast.h" #include "src/parser.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-liveedit.cc b/src/runtime/runtime-liveedit.cc index b52980a..3b8dad9 100644 --- a/src/runtime/runtime-liveedit.cc +++ b/src/runtime/runtime-liveedit.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/debug/debug.h" @@ -10,7 +10,6 @@ #include "src/debug/liveedit.h" #include "src/frames-inl.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-maths.cc b/src/runtime/runtime-maths.cc index 23b58cf..5042616 100644 --- a/src/runtime/runtime-maths.cc +++ b/src/runtime/runtime-maths.cc @@ -2,15 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/assembler.h" #include "src/codegen.h" -#include "src/runtime/runtime-utils.h" #include "src/third_party/fdlibm/fdlibm.h" - namespace v8 { namespace internal { diff --git a/src/runtime/runtime-numbers.cc b/src/runtime/runtime-numbers.cc index 7e6712a..49734ba 100644 --- a/src/runtime/runtime-numbers.cc +++ b/src/runtime/runtime-numbers.cc @@ -2,13 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/base/bits.h" #include "src/bootstrapper.h" #include "src/codegen.h" -#include "src/runtime/runtime-utils.h" #ifndef _STLP_VENDOR_CSTD diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc index 6247087..be688d2 100644 --- a/src/runtime/runtime-object.cc +++ b/src/runtime/runtime-object.cc @@ -2,14 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/bootstrapper.h" #include "src/debug/debug.h" #include "src/messages.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-observe.cc b/src/runtime/runtime-observe.cc index d1fe0b4..e4ce23f 100644 --- a/src/runtime/runtime-observe.cc +++ b/src/runtime/runtime-observe.cc @@ -2,11 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/debug/debug.h" -#include "src/runtime/runtime-utils.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-proxy.cc b/src/runtime/runtime-proxy.cc index 0f175c0..03af691 100644 --- a/src/runtime/runtime-proxy.cc +++ b/src/runtime/runtime-proxy.cc @@ -2,10 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" -#include "src/runtime/runtime-utils.h" +#include "src/factory.h" +#include "src/objects-inl.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-regexp.cc b/src/runtime/runtime-regexp.cc index 5628f3e..de671f5 100644 --- a/src/runtime/runtime-regexp.cc +++ b/src/runtime/runtime-regexp.cc @@ -2,9 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/conversions-inl.h" #include "src/messages.h" #include "src/regexp/jsregexp-inl.h" #include "src/regexp/jsregexp.h" diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc index be13a14..01c828b 100644 --- a/src/runtime/runtime-scopes.cc +++ b/src/runtime/runtime-scopes.cc @@ -2,13 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/accessors.h" #include "src/arguments.h" #include "src/frames-inl.h" #include "src/messages.h" -#include "src/runtime/runtime-utils.h" #include "src/scopeinfo.h" #include "src/scopes.h" diff --git a/src/runtime/runtime-simd.cc b/src/runtime/runtime-simd.cc index ad337ea..ce9512e8 100644 --- a/src/runtime/runtime-simd.cc +++ b/src/runtime/runtime-simd.cc @@ -2,12 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/base/macros.h" #include "src/conversions.h" -#include "src/runtime/runtime-utils.h" +#include "src/factory.h" +#include "src/objects-inl.h" // Implement Single Instruction Multiple Data (SIMD) operations as defined in // the SIMD.js draft spec: diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc index 773eefd..bb4207f 100644 --- a/src/runtime/runtime-strings.cc +++ b/src/runtime/runtime-strings.cc @@ -2,12 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/conversions-inl.h" #include "src/regexp/jsregexp-inl.h" #include "src/regexp/jsregexp.h" -#include "src/runtime/runtime-utils.h" #include "src/string-builder.h" #include "src/string-search.h" diff --git a/src/runtime/runtime-symbol.cc b/src/runtime/runtime-symbol.cc index bd4f3ed..8f99a37 100644 --- a/src/runtime/runtime-symbol.cc +++ b/src/runtime/runtime-symbol.cc @@ -2,10 +2,10 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" -#include "src/runtime/runtime-utils.h" +#include "src/objects-inl.h" namespace v8 { namespace internal { diff --git a/src/runtime/runtime-test.cc b/src/runtime/runtime-test.cc index f89358e..73f6478 100644 --- a/src/runtime/runtime-test.cc +++ b/src/runtime/runtime-test.cc @@ -2,13 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/deoptimizer.h" #include "src/frames-inl.h" #include "src/full-codegen/full-codegen.h" -#include "src/runtime/runtime-utils.h" #include "src/snapshot/natives.h" namespace v8 { diff --git a/src/runtime/runtime-typedarray.cc b/src/runtime/runtime-typedarray.cc index bfb810e..ffa4120 100644 --- a/src/runtime/runtime-typedarray.cc +++ b/src/runtime/runtime-typedarray.cc @@ -2,13 +2,13 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" +#include "src/factory.h" #include "src/messages.h" +#include "src/objects-inl.h" #include "src/runtime/runtime.h" -#include "src/runtime/runtime-utils.h" - namespace v8 { namespace internal { diff --git a/src/runtime/runtime-uri.cc b/src/runtime/runtime-uri.cc index e0eba4f..4f77af8 100644 --- a/src/runtime/runtime-uri.cc +++ b/src/runtime/runtime-uri.cc @@ -2,15 +2,14 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" +#include "src/runtime/runtime-utils.h" #include "src/arguments.h" #include "src/conversions.h" -#include "src/runtime/runtime-utils.h" +#include "src/objects-inl.h" #include "src/string-search.h" #include "src/utils.h" - namespace v8 { namespace internal { diff --git a/src/runtime/runtime.cc b/src/runtime/runtime.cc index 674f117..a490327 100644 --- a/src/runtime/runtime.cc +++ b/src/runtime/runtime.cc @@ -2,9 +2,11 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "src/v8.h" - #include "src/runtime/runtime.h" + +#include "src/handles-inl.h" +#include "src/heap/heap.h" +#include "src/isolate.h" #include "src/runtime/runtime-utils.h" namespace v8 { -- 2.7.4