From d1f756955173222578f4e9bcfca8014d5a5f2055 Mon Sep 17 00:00:00 2001 From: Sangyoon Jang Date: Tue, 14 Jul 2015 14:47:25 +0900 Subject: [PATCH] Remove some logs remove excessive pkgmgr signal logs many clients print these logs, but these are not needed that much Change-Id: I59154c3650c6ec55d31b9f79e821618c68b75d36 Signed-off-by: Sangyoon Jang --- client/src/pkgmgr.c | 20 +++++--------------- comm/comm_client_gdbus.c | 9 ++------- 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/client/src/pkgmgr.c b/client/src/pkgmgr.c index 23727d8..303f3ff 100644 --- a/client/src/pkgmgr.c +++ b/client/src/pkgmgr.c @@ -315,31 +315,25 @@ static void __operation_callback(void *cb_data, uid_t target_uid, pkgmgr_client_t *pc; req_cb_info *cb_info; - DBG("__operation_callback() target_uid[%u] req_id[%s] pkg_type[%s] " - "pkgid[%s] key[%s] val[%s]\n", - target_uid, req_id, pkg_type, pkgid, key, val); - pc = (pkgmgr_client_t *) cb_data; /* find callback info */ cb_info = __find_op_cbinfo(pc, req_id); - if (cb_info == NULL) + if (cb_info == NULL) { + ERR("cannot fint cb_info for req_id:%d", req_id); return; - - DBG("__find_op_cbinfo"); + } /* call callback */ if (cb_info->event_cb) { - if (pc->new_event_cb) { + if (pc->new_event_cb) cb_info->event_cb(target_uid, cb_info->request_id, pkg_type, pkgid, key, val, pc, cb_info->data); - } else { + else cb_info->event_cb(target_uid, cb_info->request_id, pkg_type, pkgid, key, val, NULL, cb_info->data); - } - DBG("event_cb is called"); } /*remove callback for last call @@ -360,10 +354,6 @@ static void __status_callback(void *cb_data, uid_t target_uid, pkgmgr_client_t *pc; listen_cb_info *tmp; - DBG("__status_callback() target_uid[%u] req_id[%s] pkg_type[%s] " - "pkgid[%s] key[%s] val[%s]\n", target_uid, req_id, pkg_type, - pkgid, key, val); - pc = (pkgmgr_client_t *) cb_data; tmp = pc->info.listening.lhead; diff --git a/comm/comm_client_gdbus.c b/comm/comm_client_gdbus.c index 5648268..bf9f9dd 100644 --- a/comm/comm_client_gdbus.c +++ b/comm/comm_client_gdbus.c @@ -178,17 +178,12 @@ void _on_signal_handle_filter(GDBusConnection *conn, g_variant_get(parameters, "(u&s&s&s&s&s)", &target_uid, &req_id, &pkg_type, &pkgid, &key, &val); - /* Got signal! */ - SECURE_LOGD("Got signal: [%s] %u / %s / %s / %s / %s / %s", signal_name, target_uid, req_id, - pkg_type, pkgid, key, val); /* Run signal callback if exist */ - if (sig_cb_data && sig_cb_data->cb) { + if (sig_cb_data && sig_cb_data->cb) sig_cb_data->cb(sig_cb_data->cb_data, target_uid, req_id, pkg_type, pkgid, key, val); - DBG("callback function is end"); - } - DBG("Handled signal. Exit function"); + return; } -- 2.7.4