From d153e7d0a5f2bb9b3cb59ebed8dd3f9a861ce8f7 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Mon, 19 Jul 2021 12:34:56 -0400 Subject: [PATCH] [libc++] Add a bunch of missing _LIBCPP_HIDE_FROM_ABI in We've been forgetting to add those to most of the review. To avoid forgetting in the future, I added an item in the pre-commit checklist. Differential Revision: https://reviews.llvm.org/D106287 --- libcxx/docs/Contributing.rst | 1 + libcxx/docs/DesignDocs/VisibilityMacros.rst | 6 ++++ libcxx/include/__iterator/advance.h | 6 ++++ libcxx/include/__iterator/erase_if_container.h | 1 + libcxx/include/__iterator/iter_move.h | 4 +-- libcxx/include/__iterator/iter_swap.h | 3 ++ libcxx/include/__iterator/next.h | 5 +++ libcxx/include/__iterator/prev.h | 4 +++ libcxx/include/__ranges/access.h | 20 ++++++------ libcxx/include/__ranges/all.h | 3 ++ libcxx/include/__ranges/data.h | 2 ++ libcxx/include/__ranges/drop_view.h | 17 ++++++++-- libcxx/include/__ranges/empty.h | 6 ++-- libcxx/include/__ranges/empty_view.h | 10 +++--- libcxx/include/__ranges/ref_view.h | 10 ++++-- libcxx/include/__ranges/size.h | 12 +++---- libcxx/include/__ranges/subrange.h | 29 ++++++++++++++--- libcxx/include/__ranges/transform_view.h | 44 ++++++++++++++++++++++++++ libcxx/include/__ranges/view_interface.h | 18 +++++++++-- 19 files changed, 162 insertions(+), 39 deletions(-) diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst index 0cf752f..9d52445 100644 --- a/libcxx/docs/Contributing.rst +++ b/libcxx/docs/Contributing.rst @@ -31,6 +31,7 @@ sure you don't forget anything: - Do you have tests for every public class and/or function you're adding or modifying? - Did you update the synopsis of the relevant headers? - Did you update the relevant files to track implementation status (in ``docs/Status/``)? +- Did you mark all functions and type declarations with the :ref:`proper visibility macro `? - If you added a header: - Did you add it to ``include/module.modulemap``? diff --git a/libcxx/docs/DesignDocs/VisibilityMacros.rst b/libcxx/docs/DesignDocs/VisibilityMacros.rst index 20237b7..e5aa500 100644 --- a/libcxx/docs/DesignDocs/VisibilityMacros.rst +++ b/libcxx/docs/DesignDocs/VisibilityMacros.rst @@ -5,6 +5,8 @@ Symbol Visibility Macros .. contents:: :local: +.. _visibility-macros: + Overview ======== @@ -44,6 +46,10 @@ Visibility Macros Mark a function as not being part of the ABI of any final linked image that uses it. +**_LIBCPP_INLINE_VISIBILITY** + Historical predecessor of ``_LIBCPP_HIDE_FROM_ABI`` -- please use + ``_LIBCPP_HIDE_FROM_ABI`` instead. + **_LIBCPP_HIDE_FROM_ABI_AFTER_V1** Mark a function as being hidden from the ABI (per `_LIBCPP_HIDE_FROM_ABI`) when libc++ is built with an ABI version after ABI v1. This macro is used to diff --git a/libcxx/include/__iterator/advance.h b/libcxx/include/__iterator/advance.h index 4971beb..6f7c33e 100644 --- a/libcxx/include/__iterator/advance.h +++ b/libcxx/include/__iterator/advance.h @@ -73,11 +73,13 @@ namespace ranges { struct __advance_fn final : __function_like { private: template + _LIBCPP_HIDE_FROM_ABI static constexpr _Tp __abs(_Tp __n) noexcept { return __n < 0 ? -__n : __n; } template + _LIBCPP_HIDE_FROM_ABI static constexpr void __advance_forward(_Ip& __i, iter_difference_t<_Ip> __n) { while (__n > 0) { --__n; @@ -86,6 +88,7 @@ private: } template + _LIBCPP_HIDE_FROM_ABI static constexpr void __advance_backward(_Ip& __i, iter_difference_t<_Ip> __n) { while (__n < 0) { ++__n; @@ -98,6 +101,7 @@ public: // Preconditions: If `I` does not model `bidirectional_iterator`, `n` is not negative. template + _LIBCPP_HIDE_FROM_ABI constexpr void operator()(_Ip& __i, iter_difference_t<_Ip> __n) const { _LIBCPP_ASSERT(__n >= 0 || bidirectional_iterator<_Ip>, "If `n < 0`, then `bidirectional_iterator` must be true."); @@ -121,6 +125,7 @@ public: // Preconditions: Either `assignable_from || sized_sentinel_for` is modeled, or [i, bound) denotes a range. template _Sp> + _LIBCPP_HIDE_FROM_ABI constexpr void operator()(_Ip& __i, _Sp __bound) const { // If `I` and `S` model `assignable_from`, equivalent to `i = std::move(bound)`. if constexpr (assignable_from<_Ip&, _Sp>) { @@ -144,6 +149,7 @@ public: // * If `n < 0`, [bound, i) denotes a range, `I` models `bidirectional_iterator`, and `I` and `S` model `same_as`. // Returns: `n - M`, where `M` is the difference between the the ending and starting position. template _Sp> + _LIBCPP_HIDE_FROM_ABI constexpr iter_difference_t<_Ip> operator()(_Ip& __i, iter_difference_t<_Ip> __n, _Sp __bound) const { _LIBCPP_ASSERT(__n >= 0 || (bidirectional_iterator<_Ip> && same_as<_Ip, _Sp>), "If `n < 0`, then `bidirectional_iterator && same_as` must be true."); diff --git a/libcxx/include/__iterator/erase_if_container.h b/libcxx/include/__iterator/erase_if_container.h index d31f12a..a5dfd07 100644 --- a/libcxx/include/__iterator/erase_if_container.h +++ b/libcxx/include/__iterator/erase_if_container.h @@ -22,6 +22,7 @@ _LIBCPP_PUSH_MACROS _LIBCPP_BEGIN_NAMESPACE_STD template +_LIBCPP_HIDE_FROM_ABI typename _Container::size_type __libcpp_erase_if_container(_Container& __c, _Predicate& __pred) { typename _Container::size_type __old_size = __c.size(); diff --git a/libcxx/include/__iterator/iter_move.h b/libcxx/include/__iterator/iter_move.h index e384c56af..5540799 100644 --- a/libcxx/include/__iterator/iter_move.h +++ b/libcxx/include/__iterator/iter_move.h @@ -46,7 +46,7 @@ struct __fn { // well-formed expression when treated as an unevaluated operand, [...] template requires __class_or_enum> && __unqualified_iter_move<_Ip> - [[nodiscard]] constexpr decltype(auto) operator()(_Ip&& __i) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator()(_Ip&& __i) const noexcept(noexcept(iter_move(_VSTD::forward<_Ip>(__i)))) { return iter_move(_VSTD::forward<_Ip>(__i)); @@ -59,7 +59,7 @@ struct __fn { template requires (!(__class_or_enum> && __unqualified_iter_move<_Ip>)) && requires(_Ip&& __i) { *_VSTD::forward<_Ip>(__i); } - [[nodiscard]] constexpr decltype(auto) operator()(_Ip&& __i) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator()(_Ip&& __i) const noexcept(noexcept(*_VSTD::forward<_Ip>(__i))) { if constexpr (is_lvalue_reference_v(__i))>) { diff --git a/libcxx/include/__iterator/iter_swap.h b/libcxx/include/__iterator/iter_swap.h index 1715372..d70da09 100644 --- a/libcxx/include/__iterator/iter_swap.h +++ b/libcxx/include/__iterator/iter_swap.h @@ -47,6 +47,7 @@ namespace __iter_swap { struct __fn { template requires __unqualified_iter_swap<_T1, _T2> + _LIBCPP_HIDE_FROM_ABI constexpr void operator()(_T1&& __x, _T2&& __y) const noexcept(noexcept(iter_swap(_VSTD::forward<_T1>(__x), _VSTD::forward<_T2>(__y)))) { @@ -56,6 +57,7 @@ namespace __iter_swap { template requires (!__unqualified_iter_swap<_T1, _T2>) && __readable_swappable<_T1, _T2> + _LIBCPP_HIDE_FROM_ABI constexpr void operator()(_T1&& __x, _T2&& __y) const noexcept(noexcept(ranges::swap(*_VSTD::forward<_T1>(__x), *_VSTD::forward<_T2>(__y)))) { @@ -67,6 +69,7 @@ namespace __iter_swap { !__readable_swappable<_T1, _T2>) && indirectly_movable_storable<_T1, _T2> && indirectly_movable_storable<_T2, _T1> + _LIBCPP_HIDE_FROM_ABI constexpr void operator()(_T1&& __x, _T2&& __y) const noexcept(noexcept(iter_value_t<_T2>(ranges::iter_move(__y))) && noexcept(*__y = ranges::iter_move(__x)) && diff --git a/libcxx/include/__iterator/next.h b/libcxx/include/__iterator/next.h index af719e3..1eecaa9 100644 --- a/libcxx/include/__iterator/next.h +++ b/libcxx/include/__iterator/next.h @@ -43,27 +43,32 @@ inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 namespace ranges { struct __next_fn final : private __function_like { + _LIBCPP_HIDE_FROM_ABI constexpr explicit __next_fn(__tag __x) noexcept : __function_like(__x) {} template + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x) const { ++__x; return __x; } template + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n) const { ranges::advance(__x, __n); return __x; } template _Sp> + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x, _Sp __bound) const { ranges::advance(__x, __bound); return __x; } template _Sp> + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n, _Sp __bound) const { ranges::advance(__x, __n, __bound); return __x; diff --git a/libcxx/include/__iterator/prev.h b/libcxx/include/__iterator/prev.h index f1ba2be..cb8a571 100644 --- a/libcxx/include/__iterator/prev.h +++ b/libcxx/include/__iterator/prev.h @@ -42,21 +42,25 @@ inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 namespace ranges { struct __prev_fn final : private __function_like { + _LIBCPP_HIDE_FROM_ABI constexpr explicit __prev_fn(__tag __x) noexcept : __function_like(__x) {} template + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x) const { --__x; return __x; } template + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n) const { ranges::advance(__x, -__n); return __x; } template + _LIBCPP_HIDE_FROM_ABI constexpr _Ip operator()(_Ip __x, iter_difference_t<_Ip> __n, _Ip __bound) const { ranges::advance(__x, -__n, __bound); return __x; diff --git a/libcxx/include/__ranges/access.h b/libcxx/include/__ranges/access.h index 528dba1..add8488 100644 --- a/libcxx/include/__ranges/access.h +++ b/libcxx/include/__ranges/access.h @@ -64,7 +64,7 @@ namespace ranges::__begin { struct __fn { template requires is_array_v> - [[nodiscard]] constexpr auto operator()(_Tp& __t) const noexcept { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp& __t) const noexcept { constexpr bool __complete = __is_complete >; if constexpr (__complete) { // used to disable cryptic diagnostic return __t + 0; @@ -76,7 +76,7 @@ namespace ranges::__begin { template requires __member_begin<_Tp> - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::__decay_copy(__t.begin()))) { return __t.begin(); @@ -84,7 +84,7 @@ namespace ranges::__begin { template requires __unqualified_begin<_Tp> - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::__decay_copy(begin(__t)))) { return begin(__t); @@ -129,7 +129,7 @@ namespace ranges::__end { class __fn { public: template - [[nodiscard]] constexpr auto operator()(_Tp (&__t)[_Np]) const noexcept { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp (&__t)[_Np]) const noexcept { constexpr bool __complete = __is_complete >; if constexpr (__complete) { // used to disable cryptic diagnostic return __t + _Np; @@ -141,7 +141,7 @@ namespace ranges::__end { template requires __member_end<_Tp> - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::__decay_copy(__t.end()))) { return _VSTD::forward<_Tp>(__t).end(); @@ -149,7 +149,7 @@ namespace ranges::__end { template requires __unqualified_end<_Tp> - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::__decay_copy(end(__t)))) { return end(__t); @@ -167,7 +167,7 @@ namespace ranges::__cbegin { struct __fn { template requires invocable - [[nodiscard]] constexpr auto operator()(_Tp& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp& __t) const noexcept(noexcept(ranges::begin(_VSTD::as_const(__t)))) { return ranges::begin(_VSTD::as_const(__t)); @@ -175,7 +175,7 @@ namespace ranges::__cbegin { template requires is_rvalue_reference_v<_Tp> && invocable - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::begin(static_cast<_Tp const&&>(__t)))) { return ranges::begin(static_cast<_Tp const&&>(__t)); @@ -191,7 +191,7 @@ namespace ranges::__cend { struct __fn { template requires invocable - [[nodiscard]] constexpr auto operator()(_Tp& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp& __t) const noexcept(noexcept(ranges::end(_VSTD::as_const(__t)))) { return ranges::end(_VSTD::as_const(__t)); @@ -199,7 +199,7 @@ namespace ranges::__cend { template requires is_rvalue_reference_v<_Tp> && invocable - [[nodiscard]] constexpr auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::end(static_cast<_Tp const&&>(__t)))) { return ranges::end(static_cast<_Tp const&&>(__t)); diff --git a/libcxx/include/__ranges/all.h b/libcxx/include/__ranges/all.h index 6cfe3b8..d678d3e 100644 --- a/libcxx/include/__ranges/all.h +++ b/libcxx/include/__ranges/all.h @@ -38,6 +38,7 @@ namespace __all { struct __fn { template requires ranges::view> + _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::__decay_copy(_VSTD::forward<_Tp>(__t)))) { @@ -47,6 +48,7 @@ namespace __all { template requires (!ranges::view>) && requires (_Tp&& __t) { ranges::ref_view{_VSTD::forward<_Tp>(__t)}; } + _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::ref_view{_VSTD::forward<_Tp>(__t)})) { @@ -57,6 +59,7 @@ namespace __all { requires (!ranges::view> && !requires (_Tp&& __t) { ranges::ref_view{_VSTD::forward<_Tp>(__t)}; } && requires (_Tp&& __t) { ranges::subrange{_VSTD::forward<_Tp>(__t)}; }) + _LIBCPP_HIDE_FROM_ABI constexpr auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::subrange{_VSTD::forward<_Tp>(__t)})) { diff --git a/libcxx/include/__ranges/data.h b/libcxx/include/__ranges/data.h index f001178..dae3098 100644 --- a/libcxx/include/__ranges/data.h +++ b/libcxx/include/__ranges/data.h @@ -54,6 +54,7 @@ namespace __data { struct __fn { template <__member_data _Tp> requires __can_borrow<_Tp> + _LIBCPP_HIDE_FROM_ABI constexpr __ptr_to_object auto operator()(_Tp&& __t) const noexcept(noexcept(__t.data())) { return __t.data(); @@ -61,6 +62,7 @@ namespace __data { template<__ranges_begin_invocable _Tp> requires __can_borrow<_Tp> + _LIBCPP_HIDE_FROM_ABI constexpr __ptr_to_object auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::to_address(ranges::begin(_VSTD::forward<_Tp>(__t))))) { return _VSTD::to_address(ranges::begin(_VSTD::forward<_Tp>(__t))); diff --git a/libcxx/include/__ranges/drop_view.h b/libcxx/include/__ranges/drop_view.h index 7ba74e5..7b3b8da 100644 --- a/libcxx/include/__ranges/drop_view.h +++ b/libcxx/include/__ranges/drop_view.h @@ -57,6 +57,7 @@ namespace ranges { public: drop_view() requires default_initializable<_View> = default; + _LIBCPP_HIDE_FROM_ABI constexpr drop_view(_View __base, range_difference_t<_View> __count) : __cached_begin_() , __count_(__count) @@ -65,18 +66,21 @@ public: _LIBCPP_ASSERT(__count_ >= 0, "count must be greater than or equal to zero."); } + _LIBCPP_HIDE_FROM_ABI constexpr drop_view(drop_view const& __other) : __cached_begin_() // Intentionally not propagating the cached begin iterator. , __count_(__other.__count_) , __base_(__other.__base_) { } + _LIBCPP_HIDE_FROM_ABI constexpr drop_view(drop_view&& __other) : __cached_begin_() // Intentionally not propagating the cached begin iterator. , __count_(_VSTD::move(__other.__count_)) , __base_(_VSTD::move(__other.__base_)) { } + _LIBCPP_HIDE_FROM_ABI constexpr drop_view& operator=(drop_view const& __other) { if constexpr (_UseCache) { __cached_begin_.reset(); @@ -86,6 +90,7 @@ public: return *this; } + _LIBCPP_HIDE_FROM_ABI constexpr drop_view& operator=(drop_view&& __other) { if constexpr (_UseCache) { __cached_begin_.reset(); @@ -96,9 +101,10 @@ public: return *this; } - constexpr _View base() const& requires copy_constructible<_View> { return __base_; } - constexpr _View base() && { return _VSTD::move(__base_); } + _LIBCPP_HIDE_FROM_ABI constexpr _View base() const& requires copy_constructible<_View> { return __base_; } + _LIBCPP_HIDE_FROM_ABI constexpr _View base() && { return _VSTD::move(__base_); } + _LIBCPP_HIDE_FROM_ABI constexpr auto begin() requires (!(__simple_view<_View> && random_access_range && sized_range)) @@ -113,30 +119,36 @@ public: return __tmp; } + _LIBCPP_HIDE_FROM_ABI constexpr auto begin() const requires random_access_range && sized_range { return ranges::next(ranges::begin(__base_), __count_, ranges::end(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr auto end() requires (!__simple_view<_View>) { return ranges::end(__base_); } + _LIBCPP_HIDE_FROM_ABI constexpr auto end() const requires range { return ranges::end(__base_); } + _LIBCPP_HIDE_FROM_ABI static constexpr auto __size(auto& __self) { const auto __s = ranges::size(__self.__base_); const auto __c = static_cast(__self.__count_); return __s < __c ? 0 : __s - __c; } + _LIBCPP_HIDE_FROM_ABI constexpr auto size() requires sized_range<_View> { return __size(*this); } + _LIBCPP_HIDE_FROM_ABI constexpr auto size() const requires sized_range { return __size(*this); } @@ -147,7 +159,6 @@ public: template inline constexpr bool enable_borrowed_range> = enable_borrowed_range<_Tp>; - } // namespace ranges #endif // !defined(_LIBCPP_HAS_NO_RANGES) diff --git a/libcxx/include/__ranges/empty.h b/libcxx/include/__ranges/empty.h index 186be96..73892a8 100644 --- a/libcxx/include/__ranges/empty.h +++ b/libcxx/include/__ranges/empty.h @@ -52,19 +52,19 @@ namespace __empty { struct __fn { template <__member_empty _Tp> - [[nodiscard]] constexpr bool operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool operator()(_Tp&& __t) const noexcept(noexcept(bool(__t.empty()))) { return __t.empty(); } template <__can_invoke_size _Tp> - [[nodiscard]] constexpr bool operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool operator()(_Tp&& __t) const noexcept(noexcept(ranges::size(_VSTD::forward<_Tp>(__t)))) { return ranges::size(_VSTD::forward<_Tp>(__t)) == 0; } template<__can_compare_begin_end _Tp> - [[nodiscard]] constexpr bool operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool operator()(_Tp&& __t) const noexcept(noexcept(bool(ranges::begin(__t) == ranges::end(__t)))) { return ranges::begin(__t) == ranges::end(__t); } diff --git a/libcxx/include/__ranges/empty_view.h b/libcxx/include/__ranges/empty_view.h index 9a3c2b3..7c0f307c 100644 --- a/libcxx/include/__ranges/empty_view.h +++ b/libcxx/include/__ranges/empty_view.h @@ -29,11 +29,11 @@ namespace ranges { requires is_object_v<_Tp> class empty_view : public view_interface> { public: - static constexpr _Tp* begin() noexcept { return nullptr; } - static constexpr _Tp* end() noexcept { return nullptr; } - static constexpr _Tp* data() noexcept { return nullptr; } - static constexpr size_t size() noexcept { return 0; } - static constexpr bool empty() noexcept { return true; } + _LIBCPP_HIDE_FROM_ABI static constexpr _Tp* begin() noexcept { return nullptr; } + _LIBCPP_HIDE_FROM_ABI static constexpr _Tp* end() noexcept { return nullptr; } + _LIBCPP_HIDE_FROM_ABI static constexpr _Tp* data() noexcept { return nullptr; } + _LIBCPP_HIDE_FROM_ABI static constexpr size_t size() noexcept { return 0; } + _LIBCPP_HIDE_FROM_ABI static constexpr bool empty() noexcept { return true; } }; } // namespace ranges diff --git a/libcxx/include/__ranges/ref_view.h b/libcxx/include/__ranges/ref_view.h index 1df7939..fb45a35 100644 --- a/libcxx/include/__ranges/ref_view.h +++ b/libcxx/include/__ranges/ref_view.h @@ -47,23 +47,27 @@ public: template requires __different_from<_Tp, ref_view> && convertible_to<_Tp, _Range&> && requires { __fun(declval<_Tp>()); } + _LIBCPP_HIDE_FROM_ABI constexpr ref_view(_Tp&& __t) : __range_(_VSTD::addressof(static_cast<_Range&>(_VSTD::forward<_Tp>(__t)))) {} - constexpr _Range& base() const { return *__range_; } + _LIBCPP_HIDE_FROM_ABI constexpr _Range& base() const { return *__range_; } - constexpr iterator_t<_Range> begin() const { return ranges::begin(*__range_); } - constexpr sentinel_t<_Range> end() const { return ranges::end(*__range_); } + _LIBCPP_HIDE_FROM_ABI constexpr iterator_t<_Range> begin() const { return ranges::begin(*__range_); } + _LIBCPP_HIDE_FROM_ABI constexpr sentinel_t<_Range> end() const { return ranges::end(*__range_); } + _LIBCPP_HIDE_FROM_ABI constexpr bool empty() const requires requires { ranges::empty(*__range_); } { return ranges::empty(*__range_); } + _LIBCPP_HIDE_FROM_ABI constexpr auto size() const requires sized_range<_Range> { return ranges::size(*__range_); } + _LIBCPP_HIDE_FROM_ABI constexpr auto data() const requires contiguous_range<_Range> { return ranges::data(*__range_); } diff --git a/libcxx/include/__ranges/size.h b/libcxx/include/__ranges/size.h index 999d211..ce7183e 100644 --- a/libcxx/include/__ranges/size.h +++ b/libcxx/include/__ranges/size.h @@ -68,29 +68,29 @@ namespace __size { struct __fn { template - [[nodiscard]] constexpr size_t operator()(_Tp (&&)[_Sz]) const noexcept { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr size_t operator()(_Tp (&&)[_Sz]) const noexcept { return _Sz; } template - [[nodiscard]] constexpr size_t operator()(_Tp (&)[_Sz]) const noexcept { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr size_t operator()(_Tp (&)[_Sz]) const noexcept { return _Sz; } template <__member_size _Tp> - [[nodiscard]] constexpr __integer_like auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr __integer_like auto operator()(_Tp&& __t) const noexcept(noexcept(_VSTD::forward<_Tp>(__t).size())) { return _VSTD::forward<_Tp>(__t).size(); } template <__unqualified_size _Tp> - [[nodiscard]] constexpr __integer_like auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr __integer_like auto operator()(_Tp&& __t) const noexcept(noexcept(size(_VSTD::forward<_Tp>(__t)))) { return size(_VSTD::forward<_Tp>(__t)); } template<__difference _Tp> - [[nodiscard]] constexpr __integer_like auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr __integer_like auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::end(__t) - ranges::begin(__t))) { return _VSTD::__to_unsigned_like(ranges::end(__t) - ranges::begin(__t)); } @@ -105,7 +105,7 @@ namespace __ssize { struct __fn { template requires requires (_Tp&& __t) { ranges::size(__t); } - [[nodiscard]] constexpr integral auto operator()(_Tp&& __t) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr integral auto operator()(_Tp&& __t) const noexcept(noexcept(ranges::size(__t))) { using _Signed = make_signed_t; if constexpr (sizeof(ptrdiff_t) > sizeof(_Signed)) diff --git a/libcxx/include/__ranges/subrange.h b/libcxx/include/__ranges/subrange.h index 7001c52..e3ed865 100644 --- a/libcxx/include/__ranges/subrange.h +++ b/libcxx/include/__ranges/subrange.h @@ -69,7 +69,10 @@ namespace ranges { _Iter __begin_ = _Iter(); _Sent __end_ = _Sent(); + _LIBCPP_HIDE_FROM_ABI constexpr __subrange_base() = default; + + _LIBCPP_HIDE_FROM_ABI constexpr __subrange_base(_Iter __iter, _Sent __sent, make_unsigned_t> = 0) : __begin_(_VSTD::move(__iter)), __end_(__sent) { } }; @@ -81,7 +84,10 @@ namespace ranges { _Sent __end_ = _Sent(); make_unsigned_t> __size_ = 0; + _LIBCPP_HIDE_FROM_ABI constexpr __subrange_base() = default; + + _LIBCPP_HIDE_FROM_ABI constexpr __subrange_base(_Iter __iter, _Sent __sent, decltype(__size_) __size) : __begin_(_VSTD::move(__iter)), __end_(__sent), __size_(__size) { } }; @@ -97,12 +103,15 @@ namespace ranges { using _Base = __subrange_base<_Iter, _Sent, _Kind == subrange_kind::sized && !sized_sentinel_for<_Sent, _Iter>>; + _LIBCPP_HIDE_FROM_ABI subrange() requires default_initializable<_Iter> = default; + _LIBCPP_HIDE_FROM_ABI constexpr subrange(__convertible_to_non_slicing<_Iter> auto __iter, _Sent __sent) requires (!_Base::__store_size) : _Base(_VSTD::move(__iter), __sent) {} + _LIBCPP_HIDE_FROM_ABI constexpr subrange(__convertible_to_non_slicing<_Iter> auto __iter, _Sent __sent, make_unsigned_t> __n) requires (_Kind == subrange_kind::sized) @@ -112,6 +121,7 @@ namespace ranges { requires borrowed_range<_Range> && __convertible_to_non_slicing, _Iter> && convertible_to, _Sent> + _LIBCPP_HIDE_FROM_ABI constexpr subrange(_Range&& __range) requires (!_Base::__store_size) : subrange(ranges::begin(__range), ranges::end(__range)) { } @@ -120,6 +130,7 @@ namespace ranges { requires borrowed_range<_Range> && __convertible_to_non_slicing, _Iter> && convertible_to, _Sent> + _LIBCPP_HIDE_FROM_ABI constexpr subrange(_Range&& __range) requires _Base::__store_size && sized_range<_Range> : subrange(__range, ranges::size(__range)) { } @@ -128,26 +139,31 @@ namespace ranges { template requires __convertible_to_non_slicing, _Iter> && convertible_to, _Sent> + _LIBCPP_HIDE_FROM_ABI constexpr subrange(_Range&& __range, make_unsigned_t> __n) requires (_Kind == subrange_kind::sized) : subrange(ranges::begin(__range), ranges::end(__range), __n) { } template<__different_from _Pair> requires __pair_like_convertible_from<_Pair, const _Iter&, const _Sent&> + _LIBCPP_HIDE_FROM_ABI constexpr operator _Pair() const { return _Pair(this->__begin_, this->__end_); } + _LIBCPP_HIDE_FROM_ABI constexpr _Iter begin() const requires copyable<_Iter> { return this->__begin_; } - [[nodiscard]] constexpr _Iter begin() requires (!copyable<_Iter>) { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr _Iter begin() requires (!copyable<_Iter>) { return _VSTD::move(this->__begin_); } + _LIBCPP_HIDE_FROM_ABI constexpr _Sent end() const { return this->__end_; } - [[nodiscard]] constexpr bool empty() const { return this->__begin_ == this->__end_; } + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool empty() const { return this->__begin_ == this->__end_; } + _LIBCPP_HIDE_FROM_ABI constexpr make_unsigned_t> size() const requires (_Kind == subrange_kind::sized) { @@ -157,25 +173,26 @@ namespace ranges { return __to_unsigned_like(this->__end_ - this->__begin_); } - [[nodiscard]] constexpr subrange next(iter_difference_t<_Iter> __n = 1) const& + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr subrange next(iter_difference_t<_Iter> __n = 1) const& requires forward_iterator<_Iter> { auto __tmp = *this; __tmp.advance(__n); return __tmp; } - [[nodiscard]] constexpr subrange next(iter_difference_t<_Iter> __n = 1) && { + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr subrange next(iter_difference_t<_Iter> __n = 1) && { advance(__n); return _VSTD::move(*this); } - [[nodiscard]] constexpr subrange prev(iter_difference_t<_Iter> __n = 1) const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr subrange prev(iter_difference_t<_Iter> __n = 1) const requires bidirectional_iterator<_Iter> { auto __tmp = *this; __tmp.advance(-__n); return __tmp; } + _LIBCPP_HIDE_FROM_ABI constexpr subrange& advance(iter_difference_t<_Iter> __n) { if constexpr (bidirectional_iterator<_Iter>) { if (__n < 0) { @@ -211,6 +228,7 @@ namespace ranges { template requires (_Index < 2) + _LIBCPP_HIDE_FROM_ABI constexpr auto get(const subrange<_Iter, _Sent, _Kind>& __subrange) { if constexpr (_Index == 0) return __subrange.begin(); @@ -220,6 +238,7 @@ namespace ranges { template requires (_Index < 2) + _LIBCPP_HIDE_FROM_ABI constexpr auto get(subrange<_Iter, _Sent, _Kind>&& __subrange) { if constexpr (_Index == 0) return __subrange.begin(); diff --git a/libcxx/include/__ranges/transform_view.h b/libcxx/include/__ranges/transform_view.h index 2d6f62d..9a7ffa1 100644 --- a/libcxx/include/__ranges/transform_view.h +++ b/libcxx/include/__ranges/transform_view.h @@ -52,18 +52,24 @@ class transform_view : public view_interface> { [[no_unique_address]] _View __base_ = _View(); public: + _LIBCPP_HIDE_FROM_ABI transform_view() requires default_initializable<_View> && default_initializable<_Fn> = default; + _LIBCPP_HIDE_FROM_ABI constexpr transform_view(_View __base, _Fn __func) : __func_(_VSTD::in_place, _VSTD::move(__func)), __base_(_VSTD::move(__base)) {} + _LIBCPP_HIDE_FROM_ABI constexpr _View base() const& requires copy_constructible<_View> { return __base_; } + _LIBCPP_HIDE_FROM_ABI constexpr _View base() && { return _VSTD::move(__base_); } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator begin() { return __iterator{*this, ranges::begin(__base_)}; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator begin() const requires range && regular_invocable> @@ -71,20 +77,24 @@ public: return __iterator(*this, ranges::begin(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr __sentinel end() { return __sentinel(ranges::end(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator end() requires common_range<_View> { return __iterator(*this, ranges::end(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr __sentinel end() const requires range && regular_invocable> { return __sentinel(ranges::end(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator end() const requires common_range && regular_invocable> @@ -92,7 +102,9 @@ public: return __iterator(*this, ranges::end(__base_)); } + _LIBCPP_HIDE_FROM_ABI constexpr auto size() requires sized_range<_View> { return ranges::size(__base_); } + _LIBCPP_HIDE_FROM_ABI constexpr auto size() const requires sized_range { return ranges::size(__base_); } }; @@ -153,41 +165,50 @@ public: using value_type = remove_cvref_t>>; using difference_type = range_difference_t<_Base>; + _LIBCPP_HIDE_FROM_ABI __iterator() requires default_initializable> = default; + _LIBCPP_HIDE_FROM_ABI constexpr __iterator(_Parent& __parent, iterator_t<_Base> __current) : __parent_(_VSTD::addressof(__parent)), __current_(_VSTD::move(__current)) {} // Note: `__i` should always be `__iterator`, but directly using // `__iterator` is ill-formed when `_Const` is false // (see http://wg21.link/class.copy.ctor#5). + _LIBCPP_HIDE_FROM_ABI constexpr __iterator(__iterator __i) requires _Const && convertible_to, iterator_t<_Base>> : __parent_(__i.__parent_), __current_(_VSTD::move(__i.__current_)) {} + _LIBCPP_HIDE_FROM_ABI constexpr iterator_t<_Base> base() const& requires copyable> { return __current_; } + _LIBCPP_HIDE_FROM_ABI constexpr iterator_t<_Base> base() && { return _VSTD::move(__current_); } + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator*() const noexcept(noexcept(_VSTD::invoke(*__parent_->__func_, *__current_))) { return _VSTD::invoke(*__parent_->__func_, *__current_); } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator& operator++() { ++__current_; return *this; } + _LIBCPP_HIDE_FROM_ABI constexpr void operator++(int) { ++__current_; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator operator++(int) requires forward_range<_Base> { @@ -196,6 +217,7 @@ public: return __tmp; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator& operator--() requires bidirectional_range<_Base> { @@ -203,6 +225,7 @@ public: return *this; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator operator--(int) requires bidirectional_range<_Base> { @@ -211,6 +234,7 @@ public: return __tmp; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator& operator+=(difference_type __n) requires random_access_range<_Base> { @@ -218,6 +242,7 @@ public: return *this; } + _LIBCPP_HIDE_FROM_ABI constexpr __iterator& operator-=(difference_type __n) requires random_access_range<_Base> { @@ -225,6 +250,7 @@ public: return *this; } + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator[](difference_type __n) const noexcept(noexcept(_VSTD::invoke(*__parent_->__func_, __current_[__n]))) requires random_access_range<_Base> @@ -232,30 +258,35 @@ public: return _VSTD::invoke(*__parent_->__func_, __current_[__n]); } + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const __iterator& __x, const __iterator& __y) requires equality_comparable> { return __x.__current_ == __y.__current_; } + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator<(const __iterator& __x, const __iterator& __y) requires random_access_range<_Base> { return __x.__current_ < __y.__current_; } + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator>(const __iterator& __x, const __iterator& __y) requires random_access_range<_Base> { return __x.__current_ > __y.__current_; } + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator<=(const __iterator& __x, const __iterator& __y) requires random_access_range<_Base> { return __x.__current_ <= __y.__current_; } + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator>=(const __iterator& __x, const __iterator& __y) requires random_access_range<_Base> { @@ -263,36 +294,42 @@ public: } // TODO: Fix this as soon as soon as three_way_comparable is implemented. +// _LIBCPP_HIDE_FROM_ABI // friend constexpr auto operator<=>(const __iterator& __x, const __iterator& __y) // requires random_access_range<_Base> && three_way_comparable> // { // return __x.__current_ <=> __y.__current_; // } + _LIBCPP_HIDE_FROM_ABI friend constexpr __iterator operator+(__iterator __i, difference_type __n) requires random_access_range<_Base> { return __iterator{*__i.__parent_, __i.__current_ + __n}; } + _LIBCPP_HIDE_FROM_ABI friend constexpr __iterator operator+(difference_type __n, __iterator __i) requires random_access_range<_Base> { return __iterator{*__i.__parent_, __i.__current_ + __n}; } + _LIBCPP_HIDE_FROM_ABI friend constexpr __iterator operator-(__iterator __i, difference_type __n) requires random_access_range<_Base> { return __iterator{*__i.__parent_, __i.__current_ - __n}; } + _LIBCPP_HIDE_FROM_ABI friend constexpr difference_type operator-(const __iterator& __x, const __iterator& __y) requires sized_sentinel_for, iterator_t<_Base>> { return __x.__current_ - __y.__current_; } + _LIBCPP_HIDE_FROM_ABI friend constexpr decltype(auto) iter_move(const __iterator& __i) noexcept(noexcept(*__i)) { @@ -319,27 +356,33 @@ class transform_view<_View, _Fn>::__sentinel { friend class transform_view<_View, _Fn>::__sentinel; public: + _LIBCPP_HIDE_FROM_ABI __sentinel() = default; + _LIBCPP_HIDE_FROM_ABI constexpr explicit __sentinel(sentinel_t<_Base> __end_) : __end_(__end_) {} // Note: `__i` should always be `__sentinel`, but directly using // `__sentinel` is ill-formed when `_Const` is false // (see http://wg21.link/class.copy.ctor#5). + _LIBCPP_HIDE_FROM_ABI constexpr __sentinel(__sentinel __i) requires _Const && convertible_to, sentinel_t<_Base>> : __end_(_VSTD::move(__i.__end_)) {} + _LIBCPP_HIDE_FROM_ABI constexpr sentinel_t<_Base> base() const { return __end_; } template requires sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> + _LIBCPP_HIDE_FROM_ABI friend constexpr bool operator==(const __iterator<_OtherConst>& __x, const __sentinel& __y) { return __x.__current_ == __y.__end_; } template requires sized_sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> + _LIBCPP_HIDE_FROM_ABI friend constexpr range_difference_t<__maybe_const<_OtherConst, _View>> operator-(const __iterator<_OtherConst>& __x, const __sentinel& __y) { return __x.__current_ - __y.__end_; @@ -347,6 +390,7 @@ public: template requires sized_sentinel_for, iterator_t<__maybe_const<_OtherConst, _View>>> + _LIBCPP_HIDE_FROM_ABI friend constexpr range_difference_t<__maybe_const<_OtherConst, _View>> operator-(const __sentinel& __x, const __iterator<_OtherConst>& __y) { return __x.__end_ - __y.__current_; diff --git a/libcxx/include/__ranges/view_interface.h b/libcxx/include/__ranges/view_interface.h index 6105763..62cc5fd 100644 --- a/libcxx/include/__ranges/view_interface.h +++ b/libcxx/include/__ranges/view_interface.h @@ -43,17 +43,19 @@ void __implicitly_convert_to(type_identity_t<_Tp>) noexcept; template requires is_class_v<_Derived> && same_as<_Derived, remove_cv_t<_Derived>> class view_interface : public view_base { + _LIBCPP_HIDE_FROM_ABI constexpr _Derived& __derived() noexcept { return static_cast<_Derived&>(*this); } + _LIBCPP_HIDE_FROM_ABI constexpr _Derived const& __derived() const noexcept { return static_cast<_Derived const&>(*this); } public: template - [[nodiscard]] constexpr bool empty() + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool empty() noexcept(noexcept(__implicitly_convert_to(ranges::begin(__derived()) == ranges::end(__derived())))) requires forward_range<_D2> { @@ -61,7 +63,7 @@ public: } template - [[nodiscard]] constexpr bool empty() const + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI constexpr bool empty() const noexcept(noexcept(__implicitly_convert_to(ranges::begin(__derived()) == ranges::end(__derived())))) requires forward_range { @@ -69,6 +71,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr explicit operator bool() noexcept(noexcept(ranges::empty(declval<_D2>()))) requires __can_empty<_D2> @@ -77,6 +80,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr explicit operator bool() const noexcept(noexcept(ranges::empty(declval()))) requires __can_empty @@ -85,6 +89,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr auto data() noexcept(noexcept(_VSTD::to_address(ranges::begin(__derived())))) requires contiguous_iterator> @@ -93,6 +98,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr auto data() const noexcept(noexcept(_VSTD::to_address(ranges::begin(__derived())))) requires range && contiguous_iterator> @@ -101,6 +107,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr auto size() noexcept(noexcept(ranges::end(__derived()) - ranges::begin(__derived()))) requires forward_range<_D2> @@ -110,6 +117,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr auto size() const noexcept(noexcept(ranges::end(__derived()) - ranges::begin(__derived()))) requires forward_range @@ -119,6 +127,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) front() noexcept(noexcept(*ranges::begin(__derived()))) requires forward_range<_D2> @@ -129,6 +138,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) front() const noexcept(noexcept(*ranges::begin(__derived()))) requires forward_range @@ -139,6 +149,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) back() noexcept(noexcept(*ranges::prev(ranges::end(__derived())))) requires bidirectional_range<_D2> && common_range<_D2> @@ -149,6 +160,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) back() const noexcept(noexcept(*ranges::prev(ranges::end(__derived())))) requires bidirectional_range && common_range @@ -159,6 +171,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator[](range_difference_t<_RARange> __index) noexcept(noexcept(ranges::begin(__derived())[__index])) { @@ -166,6 +179,7 @@ public: } template + _LIBCPP_HIDE_FROM_ABI constexpr decltype(auto) operator[](range_difference_t<_RARange> __index) const noexcept(noexcept(ranges::begin(__derived())[__index])) { -- 2.7.4