From d13bf8f6b19f920447719cb300fe383ae6d632c0 Mon Sep 17 00:00:00 2001 From: Yiwei Zhang Date: Mon, 10 Jul 2023 16:31:48 -0700 Subject: [PATCH] venus: fix cmd state leak across implicit reset Reset cmd states during vkBeginCommandBuffer regardless of the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT for simplicity. Cc: mesa-stable Signed-off-by: Yiwei Zhang Part-of: --- src/virtio/vulkan/vn_command_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/virtio/vulkan/vn_command_buffer.c b/src/virtio/vulkan/vn_command_buffer.c index fefa844..1d9e282 100644 --- a/src/virtio/vulkan/vn_command_buffer.c +++ b/src/virtio/vulkan/vn_command_buffer.c @@ -1015,8 +1015,8 @@ vn_BeginCommandBuffer(VkCommandBuffer commandBuffer, struct vn_instance *instance = cmd->pool->device->instance; size_t cmd_size; - vn_cs_encoder_reset(&cmd->cs); - cmd->draw_cmd_batched = 0; + /* reset regardless of VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT */ + vn_cmd_reset(cmd); struct vn_command_buffer_begin_info local_begin_info; pBeginInfo = -- 2.7.4