From d1386a88dd1654f79544e93b03985b8700a3dbea Mon Sep 17 00:00:00 2001
From: Chris Matthews <cmatthews5@apple.com>
Date: Fri, 11 May 2018 18:38:02 +0000
Subject: [PATCH] [LIT] replace output escapes wit a cdata block

CDATA blocks don't need to have XML stuff escaped. Makes sense to wrap
output in them instead of escaping.

llvm-svn: 332116
---
 llvm/utils/lit/lit/Test.py           | 6 +++---
 llvm/utils/lit/tests/xunit-output.py | 4 +---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/llvm/utils/lit/lit/Test.py b/llvm/utils/lit/lit/Test.py
index 1a454929..c6ab505 100644
--- a/llvm/utils/lit/lit/Test.py
+++ b/llvm/utils/lit/lit/Test.py
@@ -376,9 +376,9 @@ class Test:
         testcase_xml = testcase_template.format(class_name=class_name, test_name=test_name, time=elapsed_time)
         fil.write(testcase_xml)
         if self.result.code.isFailure:
-            fil.write(u">\n\t<failure >\n")
-            fil.write(escape(self.result.output))
-            fil.write(u"\n\t</failure>\n</testcase>")
+            fil.write(u">\n\t<failure ><![CDATA[")
+            fil.write(self.result.output)
+            fil.write(u"]]></failure>\n</testcase>")
         elif self.result.code == UNSUPPORTED:
             fil.write(u">\n\t<skipped />\n</testcase>\n")
         else:
diff --git a/llvm/utils/lit/tests/xunit-output.py b/llvm/utils/lit/tests/xunit-output.py
index 965a01c..352f67e 100644
--- a/llvm/utils/lit/tests/xunit-output.py
+++ b/llvm/utils/lit/tests/xunit-output.py
@@ -6,8 +6,6 @@
 # CHECK: <testsuites>
 # CHECK: <testsuite name='test-data' tests='1' failures='1' skipped='0'>
 # CHECK: <testcase classname='test-data.test-data' name='bad&amp;name.ini' time='{{[0-1]}}.{{[0-9]+}}'>
-# CHECK-NEXT: 	<failure >
-# CHECK-NEXT:&amp; &lt; &gt; "
-# CHECK-NEXT:</failure>
+# CHECK-NEXT: <failure ><![CDATA[& < > "]]></failure>
 # CHECK: </testsuite>
 # CHECK: </testsuites>
-- 
2.7.4