From d0eda244b052414cdabbdaf0103df840fa0418f1 Mon Sep 17 00:00:00 2001 From: Sangchul Lee Date: Mon, 11 Nov 2024 15:45:35 +0900 Subject: [PATCH] Add defensive codes for checking key value pair to set properties [Version] 1.1.43 [Issue Type] Improvement Change-Id: Ibfd1ab08c9ffc5b50266113cb13ca6a7b9f6d180 Signed-off-by: Sangchul Lee --- packaging/capi-media-webrtc.spec | 2 +- src/webrtc_private.c | 3 ++- src/webrtc_source_private.c | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec index d35ab6ef..b0847da5 100644 --- a/packaging/capi-media-webrtc.spec +++ b/packaging/capi-media-webrtc.spec @@ -1,6 +1,6 @@ Name: capi-media-webrtc Summary: A WebRTC library in Tizen Native API -Version: 1.1.42 +Version: 1.1.43 Release: 0 Group: Multimedia/API License: Apache-2.0 diff --git a/src/webrtc_private.c b/src/webrtc_private.c index c2931a84..2e868cd8 100644 --- a/src/webrtc_private.c +++ b/src/webrtc_private.c @@ -1750,7 +1750,8 @@ void _gst_set_element_properties(GstElement *element, GStrv key_value_pairs) while (key_value_pairs && *key_value_pairs) { key_value_pair = g_strsplit(*key_value_pairs++, "=", 2); - if (!g_strcmp0(key_value_pair[0], "") || !g_strcmp0(key_value_pair[1], "")) { + if (!g_strcmp0(key_value_pair[0], NULL) || !g_strcmp0(key_value_pair[0], "") || + !g_strcmp0(key_value_pair[1], NULL) || !g_strcmp0(key_value_pair[1], "")) { LOG_ERROR("invalid key_value_pair, key[%s], value[%s]", key_value_pair[0], key_value_pair[1]); g_strfreev(key_value_pair); continue; diff --git a/src/webrtc_source_private.c b/src/webrtc_source_private.c index 57c66e0c..f9af92b6 100644 --- a/src/webrtc_source_private.c +++ b/src/webrtc_source_private.c @@ -1193,7 +1193,8 @@ GstCaps *_gst_set_caps_additional_fields(GstCaps *caps, GStrv key_value_pairs) while (key_value_pairs && *key_value_pairs) { key_value_pair = g_strsplit(*key_value_pairs++, "=", 2); - if (!g_strcmp0(key_value_pair[0], "") || !g_strcmp0(key_value_pair[1], "")) { + if (!g_strcmp0(key_value_pair[0], NULL) || !g_strcmp0(key_value_pair[0], "") || + !g_strcmp0(key_value_pair[1], NULL) || !g_strcmp0(key_value_pair[1], "")) { LOG_ERROR("invalid key_value_pair, key[%s], value[%s]", key_value_pair[0], key_value_pair[1]); g_strfreev(key_value_pair); continue; -- 2.34.1