From d0968472c6fc3a9648caa864db39c67db57cef0d Mon Sep 17 00:00:00 2001 From: Pekka Vuorela Date: Fri, 23 Sep 2011 14:29:07 +0300 Subject: [PATCH] Adapt QGraphicsView from QInputContext to QInputPanel Change-Id: Icbb458af7914f0af3e37ac012aa7c1cbd5f3a023 Reviewed-on: http://codereview.qt-project.org/5631 Reviewed-by: Qt Sanity Bot Reviewed-by: Lars Knoll Reviewed-by: Joona Petrell --- src/widgets/graphicsview/qgraphicsitem.cpp | 37 ++++++++++++----------------- src/widgets/graphicsview/qgraphicsscene.cpp | 7 +++--- src/widgets/graphicsview/qgraphicsview.cpp | 1 - 3 files changed, 18 insertions(+), 27 deletions(-) diff --git a/src/widgets/graphicsview/qgraphicsitem.cpp b/src/widgets/graphicsview/qgraphicsitem.cpp index c0f6339..180643d 100644 --- a/src/widgets/graphicsview/qgraphicsitem.cpp +++ b/src/widgets/graphicsview/qgraphicsitem.cpp @@ -742,7 +742,7 @@ #include #include #include -#include +#include #include #ifndef QT_NO_ACCESSIBILITY # include "qaccessible.h" @@ -7373,15 +7373,10 @@ void QGraphicsItem::setInputMethodHints(Qt::InputMethodHints hints) if (!hasFocus()) return; d->scene->d_func()->updateInputMethodSensitivityInViews(); -#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) || defined(Q_OS_SYMBIAN)) QWidget *fw = QApplication::focusWidget(); if (!fw) return; - for (int i = 0 ; i < scene()->views().count() ; ++i) - if (scene()->views().at(i) == fw) - if (QInputContext *inputContext = fw->inputContext()) - inputContext->update(); -#endif + qApp->inputPanel()->update(Qt::ImHints); } /*! @@ -7398,14 +7393,15 @@ void QGraphicsItem::updateMicroFocus() if (scene()) { for (int i = 0 ; i < scene()->views().count() ; ++i) { if (scene()->views().at(i) == fw) { - if (QInputContext *inputContext = fw->inputContext()) { - inputContext->update(); + if (qApp) + qApp->inputPanel()->update(Qt::ImQueryAll); + #ifndef QT_NO_ACCESSIBILITY - // ##### is this correct - if (toGraphicsObject()) - QAccessible::updateAccessibility(toGraphicsObject(), 0, QAccessible::StateChanged); + // ##### is this correct + if (toGraphicsObject()) + QAccessible::updateAccessibility(toGraphicsObject(), 0, QAccessible::StateChanged); #endif - break; + break; } } } @@ -10206,15 +10202,12 @@ bool QGraphicsTextItem::sceneEvent(QEvent *event) case QEvent::KeyRelease: // Reset the focus widget's input context, regardless // of how this item gained or lost focus. - if (QWidget *fw = qApp->focusWidget()) { -#ifndef QT_NO_IM - if (QInputContext *qic = fw->inputContext()) { - if (event->type() == QEvent::FocusIn || event->type() == QEvent::FocusOut) - qic->reset(); - else - qic->update(); - } -#endif //QT_NO_IM + if (event->type() == QEvent::FocusIn) { + qApp->inputPanel()->reset(); + } else if (event->type() == QEvent::FocusOut) { + qApp->inputPanel()->commit(); + } else { + qApp->inputPanel()->update(Qt::ImQueryInput); } break; case QEvent::ShortcutOverride: diff --git a/src/widgets/graphicsview/qgraphicsscene.cpp b/src/widgets/graphicsview/qgraphicsscene.cpp index 1650966..2c2acc8 100644 --- a/src/widgets/graphicsview/qgraphicsscene.cpp +++ b/src/widgets/graphicsview/qgraphicsscene.cpp @@ -243,7 +243,7 @@ #include #include #include -#include +#include #include #ifndef QT_NO_ACCESSIBILITY # include @@ -821,9 +821,8 @@ void QGraphicsScenePrivate::setFocusItemHelper(QGraphicsItem *item, // automatically by removing WA_InputMethodEnabled on // the views, but if we are changing focus, we have to // do it ourselves. - for (int i = 0; i < views.size(); ++i) - if (views.at(i)->inputContext()) - views.at(i)->inputContext()->reset(); + if (qApp) + qApp->inputPanel()->commit(); } focusItem = 0; diff --git a/src/widgets/graphicsview/qgraphicsview.cpp b/src/widgets/graphicsview/qgraphicsview.cpp index b5ec8a8..279dfce 100644 --- a/src/widgets/graphicsview/qgraphicsview.cpp +++ b/src/widgets/graphicsview/qgraphicsview.cpp @@ -280,7 +280,6 @@ static const int QGRAPHICSVIEW_PREALLOC_STYLE_OPTIONS = 503; // largest prime < #include #include #include -#include #ifdef Q_WS_X11 #include #include -- 2.7.4