From d090fc021d8a7fc87bd2143997f7d28bdd408f2f Mon Sep 17 00:00:00 2001
From: "yurys@chromium.org"
 <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Wed, 16 May 2012 13:16:57 +0000
Subject: [PATCH] Web Inspector: rename ProfileView.js to CPUProfileView.js
 https://bugs.webkit.org/show_bug.cgi?id=86612

Reviewed by Pavel Feldman.

Renamed ProfileView.js to CPUProfileView.js to match the file content.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 Source/WebCore/ChangeLog                           | 61 ++++++++++++++++++++++
 Source/WebCore/WebCore.gypi                        |  2 +-
 Source/WebCore/WebCore.vcproj/WebCore.vcproj       |  8 +--
 Source/WebCore/inspector/compile-front-end.py      |  2 +-
 .../{ProfileView.js => CPUProfileView.js}          |  2 -
 .../inspector/front-end/HeapSnapshotView.js        |  2 +-
 Source/WebCore/inspector/front-end/WebKit.qrc      |  2 +-
 Source/WebCore/inspector/front-end/inspector.html  |  2 +-
 8 files changed, 70 insertions(+), 11 deletions(-)
 rename Source/WebCore/inspector/front-end/{ProfileView.js => CPUProfileView.js} (99%)

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 218846a..55604ef 100644
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,64 @@
+2012-05-16  Yury Semikhatsky  <yurys@chromium.org>
+
+        Web Inspector: rename ProfileView.js to CPUProfileView.js
+        https://bugs.webkit.org/show_bug.cgi?id=86612
+
+        Reviewed by Pavel Feldman.
+
+        Renamed ProfileView.js to CPUProfileView.js to match the file content.
+
+        * WebCore.gypi:
+        * WebCore.vcproj/WebCore.vcproj:
+        * inspector/compile-front-end.py:
+        * inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
+        (WebInspector.CPUProfileView.profileCallback):
+        (WebInspector.CPUProfileView.prototype.get statusBarItems):
+        (WebInspector.CPUProfileView.prototype.get profile):
+        (WebInspector.CPUProfileView.prototype.set profile):
+        (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
+        (WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
+        (WebInspector.CPUProfileView.prototype.get currentTree):
+        (WebInspector.CPUProfileView.prototype.set currentTree):
+        (WebInspector.CPUProfileView.prototype.willHide):
+        (WebInspector.CPUProfileView.prototype.refresh):
+        (WebInspector.CPUProfileView.prototype.refreshVisibleData):
+        (WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
+        (WebInspector.CPUProfileView.prototype.searchCanceled):
+        (WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
+        (WebInspector.CPUProfileView.prototype.performSearch):
+        (WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
+        (WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
+        (WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
+        (WebInspector.CPUProfileView.prototype.showingLastSearchResult):
+        (WebInspector.CPUProfileView.prototype._jumpToSearchResult):
+        (WebInspector.CPUProfileView.prototype._changeView.set else):
+        (WebInspector.CPUProfileView.prototype._focusClicked):
+        (WebInspector.CPUProfileView.prototype._excludeClicked):
+        (WebInspector.CPUProfileView.prototype._resetClicked):
+        (WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
+        (WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
+        (WebInspector.CPUProfileView.prototype._sortProfile):
+        (WebInspector.CPUProfileView.prototype._assignParentsInProfile):
+        (WebInspector.CPUProfileType):
+        (WebInspector.CPUProfileType.prototype.get buttonTooltip):
+        (WebInspector.CPUProfileType.prototype.buttonClicked):
+        (WebInspector.CPUProfileType.prototype.get treeItemTitle):
+        (WebInspector.CPUProfileType.prototype.get description):
+        (WebInspector.CPUProfileType.prototype.isRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.startRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.stopRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.setRecordingProfile):
+        (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
+        (WebInspector.CPUProfileType.prototype.createView):
+        (WebInspector.CPUProfileType.prototype.createTemporaryProfile):
+        (WebInspector.CPUProfileType.prototype.createProfile):
+        * inspector/front-end/HeapSnapshotView.js:
+        (WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
+        * inspector/front-end/WebKit.qrc:
+        * inspector/front-end/inspector.html:
+
 2012-05-16  Arpita Bahuguna  <arpitabahuguna@gmail.com>
 
         "border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
diff --git a/Source/WebCore/WebCore.gypi b/Source/WebCore/WebCore.gypi
index f0b70b2..f9eac37 100644
--- a/Source/WebCore/WebCore.gypi
+++ b/Source/WebCore/WebCore.gypi
@@ -6363,6 +6363,7 @@
             'inspector/front-end/CookieItemsView.js',
             'inspector/front-end/CookieParser.js',
             'inspector/front-end/CookiesTable.js',
+            'inspector/front-end/CPUProfileView.js',
             'inspector/front-end/CSSCompletions.js',
             'inspector/front-end/CSSKeywordCompletions.js',
             'inspector/front-end/CSSSelectorProfileView.js',
@@ -6442,7 +6443,6 @@
             'inspector/front-end/ProfileDataGridTree.js',
             'inspector/front-end/ProfileLauncherView.js',
             'inspector/front-end/ProfilesPanel.js',
-            'inspector/front-end/ProfileView.js',
             'inspector/front-end/PropertiesSection.js',
             'inspector/front-end/PropertiesSidebarPane.js',
             'inspector/front-end/RawSourceCode.js',
diff --git a/Source/WebCore/WebCore.vcproj/WebCore.vcproj b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
index 203c357..6c100e9 100755
--- a/Source/WebCore/WebCore.vcproj/WebCore.vcproj
+++ b/Source/WebCore/WebCore.vcproj/WebCore.vcproj
@@ -74205,6 +74205,10 @@
 					>
 				</File>
 				<File
+					RelativePath="..\inspector\front-end\CPUProfileView.js"
+					>
+				</File>
+				<File
 					RelativePath="..\inspector\front-end\CSSCompletions.js"
 					>
 				</File>
@@ -74589,10 +74593,6 @@
 					>
 				</File>
 				<File
-					RelativePath="..\inspector\front-end\ProfileView.js"
-					>
-				</File>
-				<File
 					RelativePath="..\inspector\front-end\PropertiesSection.js"
 					>
 				</File>
diff --git a/Source/WebCore/inspector/compile-front-end.py b/Source/WebCore/inspector/compile-front-end.py
index 2feea67..3ae969a 100755
--- a/Source/WebCore/inspector/compile-front-end.py
+++ b/Source/WebCore/inspector/compile-front-end.py
@@ -293,6 +293,7 @@ modules = [
         "dependencies": ["components"],
         "sources": [
             "BottomUpProfileDataGridTree.js",
+            "CPUProfileView.js",
             "CSSSelectorProfileView.js",
             "HeapSnapshot.js",
             "HeapSnapshotDataGrids.js",
@@ -305,7 +306,6 @@ modules = [
             "ProfileDataGridTree.js",
             "ProfilesPanel.js",
             "ProfileLauncherView.js",
-            "ProfileView.js",
             "TopDownProfileDataGridTree.js",
         ]
     },
diff --git a/Source/WebCore/inspector/front-end/ProfileView.js b/Source/WebCore/inspector/front-end/CPUProfileView.js
similarity index 99%
rename from Source/WebCore/inspector/front-end/ProfileView.js
rename to Source/WebCore/inspector/front-end/CPUProfileView.js
index e4d741b..b2cd5c1 100644
--- a/Source/WebCore/inspector/front-end/ProfileView.js
+++ b/Source/WebCore/inspector/front-end/CPUProfileView.js
@@ -23,8 +23,6 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-// FIXME: Rename the file.
-
 /**
  * @constructor
  * @extends {WebInspector.View}
diff --git a/Source/WebCore/inspector/front-end/HeapSnapshotView.js b/Source/WebCore/inspector/front-end/HeapSnapshotView.js
index 89334a0..7d87862 100644
--- a/Source/WebCore/inspector/front-end/HeapSnapshotView.js
+++ b/Source/WebCore/inspector/front-end/HeapSnapshotView.js
@@ -245,7 +245,7 @@ WebInspector.HeapSnapshotView.prototype = {
         this._searchFinishedCallback = finishedCallback;
 
         function matchesByName(gridNode) {
-            return ("name" in gridNode) && gridNode.name.hasSubstring(query, true);
+            return ("_name" in gridNode) && gridNode._name.hasSubstring(query, true);
         }
 
         function matchesById(gridNode) {
diff --git a/Source/WebCore/inspector/front-end/WebKit.qrc b/Source/WebCore/inspector/front-end/WebKit.qrc
index 4ca2cb2..9500e8a 100644
--- a/Source/WebCore/inspector/front-end/WebKit.qrc
+++ b/Source/WebCore/inspector/front-end/WebKit.qrc
@@ -27,6 +27,7 @@
     <file>CookieItemsView.js</file>
     <file>CookieParser.js</file>
     <file>CookiesTable.js</file>
+    <file>CPUProfileView.js</file>
     <file>CSSCompletions.js</file>
     <file>CSSKeywordCompletions.js</file>
     <file>CSSSelectorProfileView.js</file>
@@ -106,7 +107,6 @@
     <file>ProfileDataGridTree.js</file>
     <file>ProfileLauncherView.js</file>
     <file>ProfilesPanel.js</file>
-    <file>ProfileView.js</file>
     <file>PropertiesSection.js</file>
     <file>PropertiesSidebarPane.js</file>
     <file>RawSourceCode.js</file>
diff --git a/Source/WebCore/inspector/front-end/inspector.html b/Source/WebCore/inspector/front-end/inspector.html
index 7ee70bd..4942abb 100644
--- a/Source/WebCore/inspector/front-end/inspector.html
+++ b/Source/WebCore/inspector/front-end/inspector.html
@@ -166,7 +166,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     <script type="text/javascript" src="ProfileDataGridTree.js"></script>
     <script type="text/javascript" src="BottomUpProfileDataGridTree.js"></script>
     <script type="text/javascript" src="TopDownProfileDataGridTree.js"></script>
-    <script type="text/javascript" src="ProfileView.js"></script>
+    <script type="text/javascript" src="CPUProfileView.js"></script>
     <script type="text/javascript" src="CSSSelectorProfileView.js"></script>
     <script type="text/javascript" src="HeapSnapshot.js"></script>
     <script type="text/javascript" src="HeapSnapshotProxy.js"></script>
-- 
2.7.4