From d05cb6b30ff17fbb31e27f504764367a2d15fced Mon Sep 17 00:00:00 2001 From: machenbach Date: Wed, 17 Jun 2015 05:20:48 -0700 Subject: [PATCH] Revert of Added constructor call on object in InstantiateObject method (patchset #5 id:80001 of https://codereview.chromium.org/1137693003/) Reason for revert: [Sheriff] This breaks layout test expectations: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/437 See: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/437/layout-test-results/fast/dom/create-element-after-stack-overflow-pretty-diff.html Please land a needsmanualrebaseline change on the blink-side before relanding this, if the change was intended. Please include a blink trybot on relanding this. Original issue's description: > Added constructor call on object in InstantiateObject method > > I found after upgrading from 4.2.2 where apinatives.js still > existed to 4.4.56 where everything had been converted to C++ in > api-natives.cc, my constructors for ObjectTemplate instantiated objects > were no longer being called. After investigation, I noticed in > apinatives.js that a new call would handle that, but there was no > corresponding constructor call in api-natives.cc (or anywhere else > along the chain of InstantiateObject), so I added a call to > Execution::Call to actually construct the object. Forgive me if that > isn't the right place to add it (InitializeBody in objects-inl.h also > looked like a good place), or if there's a reason constructors are > not being called. > > I also added myself to the AUTHORS file in this CL. > > Committed: https://crrev.com/e61a957b2a9726294cdd2802a6a2b6e3a9ef657d > Cr-Commit-Position: refs/heads/master@{#29076} TBR=verwaest@chromium.org,svenpanne@chromium.org,dtalley@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1188233002 Cr-Commit-Position: refs/heads/master@{#29085} --- AUTHORS | 1 - src/api-natives.cc | 4 ---- 2 files changed, 5 deletions(-) diff --git a/AUTHORS b/AUTHORS index 2ac9cbf..b0a9765 100644 --- a/AUTHORS +++ b/AUTHORS @@ -98,4 +98,3 @@ Vladimir Shutoff Yu Yin Zhongping Wang 柳荣一 -David Talley \ No newline at end of file diff --git a/src/api-natives.cc b/src/api-natives.cc index 9aa6e09..72c9208 100644 --- a/src/api-natives.cc +++ b/src/api-natives.cc @@ -195,10 +195,6 @@ MaybeHandle InstantiateObject(Isolate* isolate, auto object = isolate->factory()->NewJSObject(cons); ASSIGN_RETURN_ON_EXCEPTION( isolate, result, ConfigureInstance(isolate, object, info), JSFunction); - if (!constructor->IsUndefined()) { - RETURN_ON_EXCEPTION( - isolate, Execution::Call(isolate, cons, result, 0, nullptr), JSObject); - } // TODO(dcarney): is this necessary? JSObject::MigrateSlowToFast(result, 0, "ApiNatives::InstantiateObject"); return scope.CloseAndEscape(result); -- 2.7.4