From d03b7ae1e273e871d951c94fd9626d62acee9379 Mon Sep 17 00:00:00 2001 From: msarett Date: Mon, 25 Jan 2016 08:20:55 -0800 Subject: [PATCH] Do not test images with alpha to 565 This should handle the untriaged images in Gold. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1635453002 Review URL: https://codereview.chromium.org/1635453002 --- dm/DMSrcSink.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp index 8598de7..057b6ae 100644 --- a/dm/DMSrcSink.cpp +++ b/dm/DMSrcSink.cpp @@ -288,6 +288,11 @@ Error test_gen(SkCanvas* canvas, SkData* data) { // Currently, we will avoid creating a CodecSrc for this case (see DM.cpp). SkASSERT(kGray_8_SkColorType != gen->getInfo().colorType()); + if (kOpaque_SkAlphaType != gen->getInfo().alphaType() && + kRGB_565_SkColorType == canvas->imageInfo().colorType()) { + return Error::Nonfatal("Skip testing non-opaque images to 565."); + } + SkAutoTDelete image(SkImage::NewFromGenerator(gen, nullptr)); if (!image) { return "Could not create image from codec image generator."; -- 2.7.4