From cfb609d4f6ddb8270f85ed0fd0c824be2e21469f Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Tue, 12 Mar 2013 19:05:15 +0200 Subject: [PATCH] module: Don't use lt_dlerror(), it's useless --- src/pulsecore/module.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pulsecore/module.c b/src/pulsecore/module.c index 47bcd3f..268d85d 100644 --- a/src/pulsecore/module.c +++ b/src/pulsecore/module.c @@ -66,7 +66,13 @@ pa_module* pa_module_load(pa_core *c, const char *name, const char *argument) { m->proplist = pa_proplist_new(); if (!(m->dl = lt_dlopenext(name))) { - pa_log("Failed to open module \"%s\": %s", name, lt_dlerror()); + /* We used to print the error that is returned by lt_dlerror(), but + * lt_dlerror() is useless. It returns pretty much always "file not + * found". That's because if there are any problems with loading the + * module with normal loaders, libltdl falls back to the "preload" + * loader, which never finds anything, and therefore says "file not + * found". */ + pa_log("Failed to open module \"%s\".", name); goto fail; } -- 2.7.4