From cf6b2699ca47e486f1930e3ce82d5c3d28671288 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sat, 29 Oct 2022 16:41:05 -0400 Subject: [PATCH] panfrost: Don't set job_barrier on vertex jobs This was a hack needed for the old transform feedback code. This barrier is handled by the explicit XFB emulation that we're using on Midgard now, so we don't need the barrier in the general case. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index cd6a064..e71d975 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -2658,12 +2658,8 @@ panfrost_emit_vertex_tiler_jobs(struct panfrost_batch *batch, { struct panfrost_context *ctx = batch->ctx; - /* XXX - set job_barrier in case buffers get ping-ponged and we need to - * enforce ordering, this has a perf hit! See - * KHR-GLES31.core.vertex_attrib_binding.advanced-iterations - */ unsigned vertex = panfrost_add_job(&batch->pool.base, &batch->scoreboard, - MALI_JOB_TYPE_VERTEX, true, false, + MALI_JOB_TYPE_VERTEX, false, false, ctx->indirect_draw ? batch->indirect_draw_job_id : 0, 0, vertex_job, false); -- 2.7.4