From cf5c0c5bc6c2f7810ed42bb930a32ed703a473f6 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Mon, 15 Oct 2001 12:58:48 +0000 Subject: [PATCH] * elf32-i386.c (elf_i386_relocate_section): Report some detail on bfd_reloc_outofrange and similar errors. --- bfd/ChangeLog | 3 +++ bfd/elf32-i386.c | 60 +++++++++++++++++++++++++++++--------------------------- 2 files changed, 34 insertions(+), 29 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 8abfc90..634843d 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,8 @@ 2001-10-15 Alan Modra + * elf32-i386.c (elf_i386_relocate_section): Report some detail on + bfd_reloc_outofrange and similar errors. + * elf.c (_bfd_elf_link_hash_copy_indirect): Test ind->root.type rather than ind->weakdef. * elf32-hppa.c (elf32_hppa_copy_indirect_symbol): Likewise. diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c index fe702b5..211a19c 100644 --- a/bfd/elf32-i386.c +++ b/bfd/elf32-i386.c @@ -2037,38 +2037,40 @@ elf_i386_relocate_section (output_bfd, info, input_bfd, input_section, contents, rel->r_offset, relocation, (bfd_vma) 0); - switch (r) + if (r != bfd_reloc_ok) { - case bfd_reloc_ok: - break; + const char *name; - case bfd_reloc_overflow: - { - const char *name; - - if (h != NULL) - name = h->root.root.string; - else - { - name = bfd_elf_string_from_elf_section (input_bfd, - symtab_hdr->sh_link, - sym->st_name); - if (name == NULL) - return false; - if (*name == '\0') - name = bfd_section_name (input_bfd, sec); - } - if (! ((*info->callbacks->reloc_overflow) - (info, name, howto->name, (bfd_vma) 0, - input_bfd, input_section, rel->r_offset))) - return false; - } - break; + if (h != NULL) + name = h->root.root.string; + else + { + name = bfd_elf_string_from_elf_section (input_bfd, + symtab_hdr->sh_link, + sym->st_name); + if (name == NULL) + return false; + if (*name == '\0') + name = bfd_section_name (input_bfd, sec); + } - default: - case bfd_reloc_outofrange: - abort (); - break; + if (r == bfd_reloc_overflow) + { + + if (! ((*info->callbacks->reloc_overflow) + (info, name, howto->name, (bfd_vma) 0, + input_bfd, input_section, rel->r_offset))) + return false; + } + else + { + (*_bfd_error_handler) + (_("%s(%s+0x%lx): reloc against `%s': error %d"), + bfd_archive_filename (input_bfd), + bfd_get_section_name (input_bfd, input_section), + (long) rel->r_offset, name, (int) r); + return false; + } } } -- 2.7.4